Missing comment for create_modifytable_path

Started by Etsuro Fujitaover 8 years ago3 messages
#1Etsuro Fujita
Etsuro Fujita
fujita.etsuro@lab.ntt.co.jp
1 attachment(s)

While working on adding support for tuple routing for foreign
partitions, I noticed that in create_modifytable_path, we forgot to add
a comment on its new argument 'partitioned_rels'. Attached a patch for
including that in the comments for that function.

Best regards,
Etsuro Fujita

Attachments:

create_modifytable_path-comment.patchtext/plain; charset=UTF-8; name=create_modifytable_path-comment.patch
#2Robert Haas
Robert Haas
robertmhaas@gmail.com
In reply to: Etsuro Fujita (#1)
Re: Missing comment for create_modifytable_path

On Thu, Jun 15, 2017 at 4:40 AM, Etsuro Fujita
<fujita.etsuro@lab.ntt.co.jp> wrote:

While working on adding support for tuple routing for foreign partitions, I
noticed that in create_modifytable_path, we forgot to add a comment on its
new argument 'partitioned_rels'. Attached a patch for including that in the
comments for that function.

Committed with a slight adjustment.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Etsuro Fujita
Etsuro Fujita
fujita.etsuro@lab.ntt.co.jp
In reply to: Robert Haas (#2)
Re: Missing comment for create_modifytable_path

On 2017/06/23 2:53, Robert Haas wrote:

On Thu, Jun 15, 2017 at 4:40 AM, Etsuro Fujita
<fujita.etsuro@lab.ntt.co.jp> wrote:

While working on adding support for tuple routing for foreign partitions, I
noticed that in create_modifytable_path, we forgot to add a comment on its
new argument 'partitioned_rels'. Attached a patch for including that in the
comments for that function.

Committed with a slight adjustment.

Thank you for committing this patch (and another one)!

Best regards,
Etsuro Fujita

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers