installcheck failure

Started by Joe Conwayalmost 23 years ago4 messages
#1Joe Conway
mail@joeconway.com
1 attachment(s)

I've been getting regression test failures (int8 and numeric) for the
past couple of days. Looks like it is related to the recent to_char changes.

Joe

Attachments:

regression.diffstext/plain; name=regression.diffsDownload
*** ./expected/int8.out	Fri Sep 20 09:44:55 2002
--- ./results/int8.out	Fri Mar 21 14:57:18 2003
***************
*** 160,166 ****
             |   4567890123456789
             |                123
             |   4567890123456789
!            | -4567890123456789
  (5 rows)
  
  SELECT '' AS to_char_6,  to_char(q2, 'FMS9999999999999999')    FROM INT8_TBL;
--- 160,166 ----
             |   4567890123456789
             |                123
             |   4567890123456789
!            | --4567890123456789
  (5 rows)
  
  SELECT '' AS to_char_6,  to_char(q2, 'FMS9999999999999999')    FROM INT8_TBL;
***************
*** 175,181 ****
  
  SELECT '' AS to_char_7,  to_char(q2, 'FM9999999999999999THPR') FROM INT8_TBL;
   to_char_7 |      to_char       
! -----------+--------------------
             | 456TH
             | 4567890123456789TH
             | 123RD
--- 175,181 ----
  
  SELECT '' AS to_char_7,  to_char(q2, 'FM9999999999999999THPR') FROM INT8_TBL;
   to_char_7 |       to_char       
! -----------+---------------------
             |               456TH
             |  4567890123456789TH
             |               123RD
***************
*** 185,196 ****
  
  SELECT '' AS to_char_8,  to_char(q2, 'SG9999999999999999th')   FROM INT8_TBL;	
   to_char_8 |       to_char       
! -----------+---------------------
             | +             456th
             | +4567890123456789th
             | +             123rd
             | +4567890123456789th
!            | -4567890123456789
  (5 rows)
  
  SELECT '' AS to_char_9,  to_char(q2, '0999999999999999')       FROM INT8_TBL;	
--- 185,196 ----
  
  SELECT '' AS to_char_8,  to_char(q2, 'SG9999999999999999th')   FROM INT8_TBL;	
   to_char_8 |       to_char        
! -----------+----------------------
             | +              456th
             | + 4567890123456789th
             | +              123rd
             | + 4567890123456789th
!            | --4567890123456789
  (5 rows)
  
  SELECT '' AS to_char_9,  to_char(q2, '0999999999999999')       FROM INT8_TBL;	
***************
*** 275,285 ****
  
  SELECT '' AS to_char_17, to_char(q2, '999999SG9999999999')     FROM INT8_TBL;
   to_char_17 |      to_char      
! ------------+-------------------
              |       +       456
              | 456789+0123456789
              |       +       123
              | 456789+0123456789
!             | 456789-0123456789
  (5 rows)
  
--- 275,285 ----
  
  SELECT '' AS to_char_17, to_char(q2, '999999SG9999999999')     FROM INT8_TBL;
   to_char_17 |      to_char       
! ------------+--------------------
              |       +        456
              |  456789+0123456789
              |       +        123
              |  456789+0123456789
!             | -456789-0123456789
  (5 rows)
  

======================================================================

*** ./expected/numeric.out	Fri Mar 21 07:39:27 2003
--- ./results/numeric.out	Fri Mar 21 14:57:21 2003
***************
*** 765,778 ****
  -----------+------------------------------------
             |                   .000000000000000
             |                   .000000000000000
!            | -        34338492.215397047000000
             |                  4.310000000000000
             |            7799461.411900000000000
             |              16397.038491000000000
             |              93901.577630260000000
!            | -        83028485.000000000000000
             |              74881.000000000000000
!            | -        24926804.045047420000000
  (10 rows)
  
  SELECT '' AS to_char_6,  to_char(val, 'FMS9999999999999999.999999999999999')    FROM num_data;
--- 765,778 ----
  -----------+------------------------------------
             |                   .000000000000000
             |                   .000000000000000
!            | -        -34338492.215397047000000
             |                  4.310000000000000
             |            7799461.411900000000000
             |              16397.038491000000000
             |              93901.577630260000000
!            | -        -83028485.000000000000000
             |              74881.000000000000000
!            | -        -24926804.045047420000000
  (10 rows)
  
  SELECT '' AS to_char_6,  to_char(val, 'FMS9999999999999999.999999999999999')    FROM num_data;
***************
*** 792,823 ****
  
  SELECT '' AS to_char_7,  to_char(val, 'FM9999999999999999.999999999999999THPR') FROM num_data;
   to_char_7 |       to_char        
! -----------+----------------------
!            | 0.
!            | 0.
             | <34338492.215397047>
!            | 4.31
!            | 7799461.4119
!            | 16397.038491
!            | 93901.57763026
             | <83028485.>
!            | 74881.
             | <24926804.04504742>
  (10 rows)
  
  SELECT '' AS to_char_8,  to_char(val, 'SG9999999999999999.999999999999999th')   FROM num_data;	
   to_char_8 |              to_char              
! -----------+-----------------------------------
             | +                .000000000000000
             | +                .000000000000000
!            | -        34338492.215397047000000
             | +               4.310000000000000
             | +         7799461.411900000000000
             | +           16397.038491000000000
             | +           93901.577630260000000
!            | -        83028485.000000000000000
             | +           74881.000000000000000
!            | -        24926804.045047420000000
  (10 rows)
  
  SELECT '' AS to_char_9,  to_char(val, '0999999999999999.999999999999999')       FROM num_data;	
--- 792,823 ----
  
  SELECT '' AS to_char_7,  to_char(val, 'FM9999999999999999.999999999999999THPR') FROM num_data;
   to_char_7 |               to_char               
! -----------+-------------------------------------
!            |                  .000000000000000TH
!            |                  .000000000000000TH
             | <34338492.215397047>
!            |                 4.310000000000000TH
!            |           7799461.411900000000000TH
!            |             16397.038491000000000TH
!            |             93901.577630260000000TH
             | <83028485.>
!            |             74881.000000000000000TH
             | <24926804.04504742>
  (10 rows)
  
  SELECT '' AS to_char_8,  to_char(val, 'SG9999999999999999.999999999999999th')   FROM num_data;	
   to_char_8 |              to_char               
! -----------+------------------------------------
             | +                 .000000000000000
             | +                 .000000000000000
!            | -        -34338492.215397047000000
             | +                4.310000000000000
             | +          7799461.411900000000000
             | +            16397.038491000000000
             | +            93901.577630260000000
!            | -        -83028485.000000000000000
             | +            74881.000000000000000
!            | -        -24926804.045047420000000
  (10 rows)
  
  SELECT '' AS to_char_9,  to_char(val, '0999999999999999.999999999999999')       FROM num_data;	
***************
*** 958,965 ****
  SELECT '' AS to_char_18, to_char(val, 'S 9 9 9 9 9 9 9 9 9 9 9 9 9 9 9 9 . 9 9 9 9 9 9 9 9 9 9 9 9 9 9 9 9 9') FROM num_data;
   to_char_18 |                                to_char                                
  ------------+-----------------------------------------------------------------------
!             |                                 . +0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 
!             |                                 . +0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 
              |                 -3 4 3 3 8 4 9 2 . 2 1 5 3 9 7 0 4 7 0 0 0 0 0 0 0 0 
              |                               +4 . 3 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 
              |                   +7 7 9 9 4 6 1 . 4 1 1 9 0 0 0 0 0 0 0 0 0 0 0 0 0 
--- 958,965 ----
  SELECT '' AS to_char_18, to_char(val, 'S 9 9 9 9 9 9 9 9 9 9 9 9 9 9 9 9 . 9 9 9 9 9 9 9 9 9 9 9 9 9 9 9 9 9') FROM num_data;
   to_char_18 |                                to_char                                
  ------------+-----------------------------------------------------------------------
!             |                                 +. 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 
!             |                                 +. 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 
              |                 -3 4 3 3 8 4 9 2 . 2 1 5 3 9 7 0 4 7 0 0 0 0 0 0 0 0 
              |                               +4 . 3 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 
              |                   +7 7 9 9 4 6 1 . 4 1 1 9 0 0 0 0 0 0 0 0 0 0 0 0 0 
***************
*** 1002,1018 ****
  
  SELECT '' AS to_char_21, to_char(val, '999999SG9999999999')			FROM num_data;
   to_char_21 |      to_char      
! ------------+-------------------
              |       +         0
              |       +         0
!             |       -  34338492
              |       +         4
              |       +   7799461
              |       +     16397
              |       +     93902
!             |       -  83028485
              |       +     74881
!             |       -  24926804
  (10 rows)
  
  SELECT '' AS to_char_22, to_char(val, 'FM9999999999999999.999999999999999')	FROM num_data;
--- 1002,1018 ----
  
  SELECT '' AS to_char_21, to_char(val, '999999SG9999999999')			FROM num_data;
   to_char_21 |      to_char       
! ------------+--------------------
              |       +          0
              |       +          0
!             |       -  -34338492
              |       +          4
              |       +    7799461
              |       +      16397
              |       +      93902
!             |       -  -83028485
              |       +      74881
!             |       -  -24926804
  (10 rows)
  
  SELECT '' AS to_char_22, to_char(val, 'FM9999999999999999.999999999999999')	FROM num_data;

======================================================================

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Joe Conway (#1)
Re: installcheck failure

Joe Conway <mail@joeconway.com> writes:

I've been getting regression test failures (int8 and numeric) for the
past couple of days. Looks like it is related to the recent to_char changes.

Yeah, Bruce applied a to_char change that really wasn't ready, because
(a) it didn't include the necessary regression updates, and (b) it
introduced some new bugs.

regards, tom lane

#3Bruce Momjian
pgman@candle.pha.pa.us
In reply to: Tom Lane (#2)
Re: installcheck failure

Tom Lane wrote:

Joe Conway <mail@joeconway.com> writes:

I've been getting regression test failures (int8 and numeric) for the
past couple of days. Looks like it is related to the recent to_char changes.

Yeah, Bruce applied a to_char change that really wasn't ready, because
(a) it didn't include the necessary regression updates, and (b) it
introduced some new bugs.

Yes, I gave Karel 2 days, and now I will clean it up.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
#4Bruce Momjian
pgman@candle.pha.pa.us
In reply to: Tom Lane (#2)
Re: installcheck failure

Patch backed out.

---------------------------------------------------------------------------

Tom Lane wrote:

Joe Conway <mail@joeconway.com> writes:

I've been getting regression test failures (int8 and numeric) for the
past couple of days. Looks like it is related to the recent to_char changes.

Yeah, Bruce applied a to_char change that really wasn't ready, because
(a) it didn't include the necessary regression updates, and (b) it
introduced some new bugs.

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 2: you can get off all lists at once with the unregister command
(send "unregister YourEmailAddressHere" to majordomo@postgresql.org)

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073