compile failure on cvs tip --with-krb5

On Fri, Jun 20, 2003 at 07:48:02PM -0700, Joe Conway wrote:

This change (I'm sure this will wrap poorly -- sorry):
http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/include/libpq/pqcomm.h.diff?r1=1.85&r2=1.86

modified SockAddr, but no corresponding change was made here
(fe-auth.c:612):

case AUTH_REQ_KRB5:
#ifdef KRB5
if (pg_krb5_sendauth(PQerrormsg, conn->sock, &conn->laddr.in,
&conn->raddr.in,
hostname) != STATUS_OK)

It's not obvious to me what the change ought to be though.

Please try the attached patch.

I'll try to change kerberos 4 later if I can find some
documentation about it. Especially the krb_sendauth() function.

Does Kerberos 4 support other protocols than ipv4?

Kurt

On Fri, Jun 20, 2003 at 07:48:02PM -0700, Joe Conway wrote:

This change (I'm sure this will wrap poorly -- sorry):
http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/include/libpq/pqcomm.h.diff?r1=1.85&r2=1.86

modified SockAddr, but no corresponding change was made here
(fe-auth.c:612):

case AUTH_REQ_KRB5:
#ifdef KRB5
if (pg_krb5_sendauth(PQerrormsg, conn->sock, &conn->laddr.in,
&conn->raddr.in,
hostname) != STATUS_OK)

It's not obvious to me what the change ought to be though.

This patch should hopefully fix both kerberos 4 and 5.

Kurt

Kurt Roeckx wrote:

This patch should hopefully fix both kerberos 4 and 5.

Thanks, the patch fixes the compile issue for me.

Disclaimer: I can't vouch for krb4 at all. And, although I compile
support for krb5, I do that to find build problems, not because I use
krb5. So I can't really speak to the correctness of the fix.

Joe

This change (I'm sure this will wrap poorly -- sorry):
http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/include/libpq/pqcomm.h.diff?r1=1.85&r2=1.86

modified SockAddr, but no corresponding change was made here
(fe-auth.c:612):

case AUTH_REQ_KRB5:
#ifdef KRB5
if (pg_krb5_sendauth(PQerrormsg, conn->sock, &conn->laddr.in,
&conn->raddr.in,
hostname) != STATUS_OK)

It's not obvious to me what the change ought to be though.

Please try the attached patch.

I'll try to change kerberos 4 later if I can find some
documentation about it. Especially the krb_sendauth() function.

Does Kerberos 4 support other protocols than ipv4?

Not that I'm aware of. -sc

--
Sean Chittenden

Your patch has been added to the PostgreSQL unapplied patches list at:

http://momjian.postgresql.org/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

---------------------------------------------------------------------------

Kurt Roeckx wrote:

On Fri, Jun 20, 2003 at 07:48:02PM -0700, Joe Conway wrote:

This change (I'm sure this will wrap poorly -- sorry):
http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/include/libpq/pqcomm.h.diff?r1=1.85&r2=1.86

modified SockAddr, but no corresponding change was made here
(fe-auth.c:612):

case AUTH_REQ_KRB5:
#ifdef KRB5
if (pg_krb5_sendauth(PQerrormsg, conn->sock, &conn->laddr.in,
&conn->raddr.in,
hostname) != STATUS_OK)

It's not obvious to me what the change ought to be though.

This patch should hopefully fix both kerberos 4 and 5.

Kurt

[ Attachment, skipping... ]

---------------------------(end of broadcast)---------------------------
TIP 5: Have you checked our extensive FAQ?

http://www.postgresql.org/docs/faqs/FAQ.html

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Patch applied. Thanks.

---------------------------------------------------------------------------

Kurt Roeckx wrote:

On Fri, Jun 20, 2003 at 07:48:02PM -0700, Joe Conway wrote:

This change (I'm sure this will wrap poorly -- sorry):
http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/include/libpq/pqcomm.h.diff?r1=1.85&r2=1.86

modified SockAddr, but no corresponding change was made here
(fe-auth.c:612):

case AUTH_REQ_KRB5:
#ifdef KRB5
if (pg_krb5_sendauth(PQerrormsg, conn->sock, &conn->laddr.in,
&conn->raddr.in,
hostname) != STATUS_OK)

It's not obvious to me what the change ought to be though.

This patch should hopefully fix both kerberos 4 and 5.

Kurt

[ Attachment, skipping... ]

---------------------------(end of broadcast)---------------------------
TIP 5: Have you checked our extensive FAQ?

http://www.postgresql.org/docs/faqs/FAQ.html

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073