pgsql-server/ oc/src/sgml/ref/alter_table.sgml ...

Tom Lane wrote:

CVSROOT: /cvsroot
Module name: pgsql-server
Changes by: tgl@svr1.postgresql.org 04/03/23 15:35:17

Modified files:
doc/src/sgml/ref: alter_table.sgml
src/backend/bootstrap: bootparse.y
src/backend/catalog: heap.c
src/backend/commands: cluster.c tablecmds.c
src/backend/executor: execMain.c
src/backend/tcop: utility.c
src/include/catalog: heap.h
src/include/commands: tablecmds.h
src/test/regress/expected: alter_table.out
src/test/regress/sql: alter_table.sql

Log message:
Upgrade ALTER TABLE DROP COLUMN so that it can drop an OID column, and
remove separate implementation of ALTER TABLE SET WITHOUT OIDS in favor
of doing a regular DROP. Also, cause CREATE TABLE to account completely
correctly for the inheritance status of the OID column. This fixes
problems with dropping OID columns that have dependencies, as noted by
Christopher Kings-Lynne, as well as making sure that you can't drop an
OID column that was inherited from a parent.

Does removing SET WITHOUT OIDS cause compatibility problems? I don't
imagine it is used very much.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Bruce Momjian <pgman@candle.pha.pa.us> writes:

Upgrade ALTER TABLE DROP COLUMN so that it can drop an OID column, and
remove separate implementation of ALTER TABLE SET WITHOUT OIDS in favor
of doing a regular DROP.

Does removing SET WITHOUT OIDS cause compatibility problems?

I didn't remove the command, I only replaced its implementation with a
call to AlterTableDropColumn.

regards, tom lane

Tom Lane wrote:

Bruce Momjian <pgman@candle.pha.pa.us> writes:

Upgrade ALTER TABLE DROP COLUMN so that it can drop an OID column, and
remove separate implementation of ALTER TABLE SET WITHOUT OIDS in favor
of doing a regular DROP.

Does removing SET WITHOUT OIDS cause compatibility problems?

I didn't remove the command, I only replaced its implementation with a
call to AlterTableDropColumn.

OK, thanks.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

On 23-Mar-04, at 3:03 PM, Bruce Momjian wrote:

Does removing SET WITHOUT OIDS cause compatibility problems?

ALTER TABLE ... SET WITHOUT OIDS has not been removed.

-Neil