pgsql-server: Add code to identify_system_timezone() to try all zones in

Started by Nonameover 21 years ago3 messages
#1Noname
tgl@svr1.postgresql.org

Log Message:
-----------
Add code to identify_system_timezone() to try all zones in the zic
database, not just ones that we cons up POSIX names for. This looks
grim but it seems to take less than a second even on a relatively slow
machine, and since it only happens once during postmaster startup, that
seems acceptable.

Modified Files:
--------------
pgsql-server/src/timezone:
pgtz.c (r1.14 -> r1.15)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/timezone/pgtz.c.diff?r1=1.14&r2=1.15)

#2Alvaro Herrera
alvherre@dcc.uchile.cl
In reply to: Noname (#1)
Re: [COMMITTERS] pgsql-server: Add code to identify_system_timezone() to try all zones in

On Tue, May 25, 2004 at 03:08:59PM -0300, Tom Lane wrote:

Add code to identify_system_timezone() to try all zones in the zic
database, not just ones that we cons up POSIX names for. This looks
grim but it seems to take less than a second even on a relatively slow
machine, and since it only happens once during postmaster startup, that
seems acceptable.

Is it possible to execute this at initdb time to set the default
timezone in postgresql.conf? The user could get a message about what
timezone was selected, and be offered a --command-line-switch to select
a specific one.

Just an idea ...

--
Alvaro Herrera (<alvherre[a]dcc.uchile.cl>)
"Ninguna manada de bestias tiene una voz tan horrible como la humana" (Orual)

#3Bruce Momjian
pgman@candle.pha.pa.us
In reply to: Alvaro Herrera (#2)
Re: [COMMITTERS] pgsql-server: Add code to identify_system_timezone()

Alvaro Herrera wrote:

On Tue, May 25, 2004 at 03:08:59PM -0300, Tom Lane wrote:

Add code to identify_system_timezone() to try all zones in the zic
database, not just ones that we cons up POSIX names for. This looks
grim but it seems to take less than a second even on a relatively slow
machine, and since it only happens once during postmaster startup, that
seems acceptable.

Is it possible to execute this at initdb time to set the default
timezone in postgresql.conf? The user could get a message about what
timezone was selected, and be offered a --command-line-switch to select
a specific one.

Just an idea ...

But if they change the OS timezone, we need to track that on postmaster
restart.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073