pgsql-server: Support renaming of tablespaces, and changing the owners

Started by Nonameover 21 years ago5 messages
#1Noname
tgl@svr1.postgresql.org

Log Message:
-----------
Support renaming of tablespaces, and changing the owners of
aggregates, conversions, functions, operators, operator classes,
schemas, types, and tablespaces. Fold the existing implementations
of alter domain owner and alter database owner in with these.

Christopher Kings-Lynne

Modified Files:
--------------
pgsql-server/doc/src/sgml/ref:
allfiles.sgml (r1.58 -> r1.59)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/doc/src/sgml/ref/allfiles.sgml.diff?r1=1.58&r2=1.59)
alter_aggregate.sgml (r1.4 -> r1.5)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/doc/src/sgml/ref/alter_aggregate.sgml.diff?r1=1.4&r2=1.5)
alter_conversion.sgml (r1.4 -> r1.5)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/doc/src/sgml/ref/alter_conversion.sgml.diff?r1=1.4&r2=1.5)
alter_function.sgml (r1.4 -> r1.5)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/doc/src/sgml/ref/alter_function.sgml.diff?r1=1.4&r2=1.5)
alter_opclass.sgml (r1.4 -> r1.5)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/doc/src/sgml/ref/alter_opclass.sgml.diff?r1=1.4&r2=1.5)
alter_schema.sgml (r1.6 -> r1.7)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/doc/src/sgml/ref/alter_schema.sgml.diff?r1=1.6&r2=1.7)
create_operator.sgml (r1.41 -> r1.42)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/doc/src/sgml/ref/create_operator.sgml.diff?r1=1.41&r2=1.42)
create_schema.sgml (r1.12 -> r1.13)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/doc/src/sgml/ref/create_schema.sgml.diff?r1=1.12&r2=1.13)
create_tablespace.sgml (r1.1 -> r1.2)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/doc/src/sgml/ref/create_tablespace.sgml.diff?r1=1.1&r2=1.2)
create_type.sgml (r1.51 -> r1.52)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/doc/src/sgml/ref/create_type.sgml.diff?r1=1.51&r2=1.52)
drop_operator.sgml (r1.24 -> r1.25)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/doc/src/sgml/ref/drop_operator.sgml.diff?r1=1.24&r2=1.25)
drop_tablespace.sgml (r1.1 -> r1.2)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/doc/src/sgml/ref/drop_tablespace.sgml.diff?r1=1.1&r2=1.2)
drop_type.sgml (r1.25 -> r1.26)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/doc/src/sgml/ref/drop_type.sgml.diff?r1=1.25&r2=1.26)
pgsql-server/doc/src/sgml:
reference.sgml (r1.49 -> r1.50)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/doc/src/sgml/reference.sgml.diff?r1=1.49&r2=1.50)
pgsql-server/src/backend/commands:
aggregatecmds.c (r1.18 -> r1.19)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/backend/commands/aggregatecmds.c.diff?r1=1.18&r2=1.19)
alter.c (r1.7 -> r1.8)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/backend/commands/alter.c.diff?r1=1.7&r2=1.8)
conversioncmds.c (r1.12 -> r1.13)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/backend/commands/conversioncmds.c.diff?r1=1.12&r2=1.13)
dbcommands.c (r1.136 -> r1.137)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/backend/commands/dbcommands.c.diff?r1=1.136&r2=1.137)
functioncmds.c (r1.48 -> r1.49)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/backend/commands/functioncmds.c.diff?r1=1.48&r2=1.49)
opclasscmds.c (r1.25 -> r1.26)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/backend/commands/opclasscmds.c.diff?r1=1.25&r2=1.26)
operatorcmds.c (r1.16 -> r1.17)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/backend/commands/operatorcmds.c.diff?r1=1.16&r2=1.17)
schemacmds.c (r1.19 -> r1.20)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/backend/commands/schemacmds.c.diff?r1=1.19&r2=1.20)
tablecmds.c (r1.116 -> r1.117)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/backend/commands/tablecmds.c.diff?r1=1.116&r2=1.117)
tablespace.c (r1.3 -> r1.4)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/backend/commands/tablespace.c.diff?r1=1.3&r2=1.4)
typecmds.c (r1.60 -> r1.61)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/backend/commands/typecmds.c.diff?r1=1.60&r2=1.61)
pgsql-server/src/backend/nodes:
copyfuncs.c (r1.286 -> r1.287)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/backend/nodes/copyfuncs.c.diff?r1=1.286&r2=1.287)
equalfuncs.c (r1.225 -> r1.226)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/backend/nodes/equalfuncs.c.diff?r1=1.225&r2=1.226)
pgsql-server/src/backend/parser:
gram.y (r2.462 -> r2.463)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/backend/parser/gram.y.diff?r1=2.462&r2=2.463)
pgsql-server/src/backend/tcop:
utility.c (r1.219 -> r1.220)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/backend/tcop/utility.c.diff?r1=1.219&r2=1.220)
pgsql-server/src/include/commands:
alter.h (r1.3 -> r1.4)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/include/commands/alter.h.diff?r1=1.3&r2=1.4)
conversioncmds.h (r1.6 -> r1.7)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/include/commands/conversioncmds.h.diff?r1=1.6&r2=1.7)
dbcommands.h (r1.31 -> r1.32)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/include/commands/dbcommands.h.diff?r1=1.31&r2=1.32)
defrem.h (r1.58 -> r1.59)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/include/commands/defrem.h.diff?r1=1.58&r2=1.59)
schemacmds.h (r1.6 -> r1.7)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/include/commands/schemacmds.h.diff?r1=1.6&r2=1.7)
tablespace.h (r1.1 -> r1.2)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/include/commands/tablespace.h.diff?r1=1.1&r2=1.2)
pgsql-server/src/include/nodes:
nodes.h (r1.158 -> r1.159)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/include/nodes/nodes.h.diff?r1=1.158&r2=1.159)
parsenodes.h (r1.259 -> r1.260)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/include/nodes/parsenodes.h.diff?r1=1.259&r2=1.260)

Added Files:
-----------
pgsql-server/doc/src/sgml/ref:
alter_operator.sgml (r1.1)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/doc/src/sgml/ref/alter_operator.sgml?rev=1.1&content-type=text/x-cvsweb-markup)
alter_tablespace.sgml (r1.1)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/doc/src/sgml/ref/alter_tablespace.sgml?rev=1.1&content-type=text/x-cvsweb-markup)
alter_type.sgml (r1.1)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/doc/src/sgml/ref/alter_type.sgml?rev=1.1&content-type=text/x-cvsweb-markup)

#2Christopher Kings-Lynne
chriskl@familyhealth.com.au
In reply to: Noname (#1)
Re: [COMMITTERS] pgsql-server: Support renaming of tablespaces, and

Support renaming of tablespaces, and changing the owners of
aggregates, conversions, functions, operators, operator classes,
schemas, types, and tablespaces. Fold the existing implementations
of alter domain owner and alter database owner in with these.

Regression tests weren't appropriate?

Chris

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Christopher Kings-Lynne (#2)
Re: [COMMITTERS] pgsql-server: Support renaming of tablespaces, and

Christopher Kings-Lynne <chriskl@familyhealth.com.au> writes:

Regression tests weren't appropriate?

Didn't like em ... as you observed, there were parallelization issues,
and in any case I'm not convinced they were testing anything very likely
to break.

regards, tom lane

#4Christopher Kings-Lynne
chriskl@familyhealth.com.au
In reply to: Tom Lane (#3)
Re: [COMMITTERS] pgsql-server: Support renaming of tablespaces,

Didn't like em ... as you observed, there were parallelization issues,
and in any case I'm not convinced they were testing anything very likely
to break.

Oh well, your call :)

Chris

#5Christopher Kings-Lynne
chriskl@familyhealth.com.au
In reply to: Tom Lane (#3)
Re: [COMMITTERS] pgsql-server: Support renaming of tablespaces,

Regression tests weren't appropriate?

Didn't like em ... as you observed, there were parallelization issues,
and in any case I'm not convinced they were testing anything very likely
to break.

Either way, I plan to dedicate tomorrow to completing pg_dump support
for all those new functions, hopefully not too late for freeze.

Chris