model-writtenrun 7961 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Condor reported that PostgreSQL 13.0 and 13.1 failed to compile on Slackware with ICU 68.1 because TRUE was undefined in get_icu_language_tag(), and asked whether substituting IS_TRUE was valid #1.
- Laurenz Albe initially investigated ICU header inclusion, while Thomas Munro identified ICU's removal of boolean macros; Tom Lane questioned the remaining uppercase TRUE and rejected indiscriminate additions of stdbool.h #2 #3 #6.
- Laurenz Albe posted a tested patch restoring TRUE and FALSE definitions for ICU 68 and later, but Tom Lane rejected restoring the deprecated macros and proposed changing the single call argument to true #7 #8.
- Tom Lane considered compatibility with platforms that do not use stdbool.h, then set that concern aside because the known affected platform could not satisfy ICU 68's C++11 requirement #8 #9.
- Tom Lane tested the one-line replacement with ICU 68.1 and committed it as ad84ecc98d, backpatched through PostgreSQL 11; the attached compatibility-macro patch was not used #10 #7.
- Condor subsequently reported linker errors after applying the substitution, which Thomas Munro traced to shell redirection truncating collationcmds.c; using a temporary file resolved the problem, and Condor confirmed successful compilation and operation #11 #12 #13.
- The thread ended with the fix committed and the reporter's build working; Peter Eisentraut explained that uppercase TRUE had originally been retained to follow ICU's documented API and agreed that the changed API justified the replacement #13 #14.