pgsql-server: Make listen_addresses be a comma-separated list instead of
Log Message:
-----------
Make listen_addresses be a comma-separated list instead of a space-separated
list. More consistent with our other list-containing GUC variables.
Modified Files:
--------------
pgsql-server/doc/src/sgml:
runtime.sgml (r1.274 -> r1.275)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/doc/src/sgml/runtime.sgml.diff?r1=1.274&r2=1.275)
pgsql-server/src/backend/postmaster:
postmaster.c (r1.420 -> r1.421)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/backend/postmaster/postmaster.c.diff?r1=1.420&r2=1.421)
pgsql-server/src/backend/utils/misc:
guc.c (r1.229 -> r1.230)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/backend/utils/misc/guc.c.diff?r1=1.229&r2=1.230)
Hey Tom,
If you've just made this a GUC_LIST_INPUT variable, then you will need
to update the nasty bit of hackiness in pg_dumpall to allow it to be
dumped without error :(
It's line 782 of pg_dumpall.c. I wonder if you will like that code once
you look at it :P
The problem is there's no way to know if they're list type gucs when
dumping, unless we modify the pg_settings view or something.
Chris
Tom Lane wrote:
Show quoted text
Log Message:
-----------
Make listen_addresses be a comma-separated list instead of a space-separated
list. More consistent with our other list-containing GUC variables.Modified Files:
--------------
pgsql-server/doc/src/sgml:
runtime.sgml (r1.274 -> r1.275)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/doc/src/sgml/runtime.sgml.diff?r1=1.274&r2=1.275)
pgsql-server/src/backend/postmaster:
postmaster.c (r1.420 -> r1.421)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/backend/postmaster/postmaster.c.diff?r1=1.420&r2=1.421)
pgsql-server/src/backend/utils/misc:
guc.c (r1.229 -> r1.230)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/backend/utils/misc/guc.c.diff?r1=1.229&r2=1.230)---------------------------(end of broadcast)---------------------------
TIP 7: don't forget to increase your free space map settings
Christopher Kings-Lynne <chriskl@familyhealth.com.au> writes:
If you've just made this a GUC_LIST_INPUT variable, then you will need
to update the nasty bit of hackiness in pg_dumpall to allow it to be
dumped without error :(
Dumped by what? It's a PGC_POSTMASTER variable, there ain't gonna be
nobody putting it in ALTER DATABASE or ALTER USER.
The problem is there's no way to know if they're list type gucs when
dumping, unless we modify the pg_settings view or something.
Yeah, it might be nice to have an API to get at those flag bits.
regards, tom lane
Dumped by what? It's a PGC_POSTMASTER variable, there ain't gonna be
nobody putting it in ALTER DATABASE or ALTER USER.
Oh yeah, sorry wasn't thinking. Same reason I don't bother handling
preload_libraries and friends in pg_dumpall...
The problem is there's no way to know if they're list type gucs when
dumping, unless we modify the pg_settings view or something.Yeah, it might be nice to have an API to get at those flag bits.
Will become more annoying once we have a binary dump format for
pg_dumpall I guess, have to store them in the binary.
Chris