returning modified input from C functions

Started by strkover 21 years ago4 messages
#1strk
strk@keybit.net

Is returning a pointer to the input safe in every case ?

--strk;

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: strk (#1)
Re: returning modified input from C functions

strk <strk@keybit.net> writes:

Is returning a pointer to the input safe in every case ?

You mean for returning *unmodified* input, don't you?

Yes, that's safe. Scribbling on input values is definitely never safe.

regards, tom lane

#3strk
strk@keybit.net
In reply to: Tom Lane (#2)
Re: returning modified input from C functions

On Mon, Aug 23, 2004 at 03:20:09PM -0400, Tom Lane wrote:

strk <strk@keybit.net> writes:

Is returning a pointer to the input safe in every case ?

You mean for returning *unmodified* input, don't you?

Yes, that's safe. Scribbling on input values is definitely never safe.

regards, tom lane

I meant scribbling actually.
Would PG_DETOAST_DATUM_COPY() make it safe then ?

--strk;

#4Tom Lane
tgl@sss.pgh.pa.us
In reply to: strk (#3)
Re: returning modified input from C functions

strk <strk@keybit.net> writes:

I meant scribbling actually.
Would PG_DETOAST_DATUM_COPY() make it safe then ?

Yup, that's what it's for.

regards, tom lane