model-writtenrun 374 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- William Bernbaum reported that dropped identity columns caused pg_dump to emit a harmless but noisy OVERRIDING SYSTEM VALUE clause and proposed ignoring dropped attributes when setting needs_override; clearing catalog markers during DROP COLUMN would not fix existing stale entries #1.
- Andreas Karlsson requested a clearer conditional and tests within the existing pg_dump suite, recommended git format-patch after encountering application difficulties, and asked whether adjacent flags suffered the same problem #2 #3.
- William returned with a revision adopting those suggestions, covering COPY and both INSERT formats, and explaining that existing catalog cleanup already protected generated-column and default flags #4.
- Fujii Masao approved the revision and asked whether the harmless issue warranted backpatching, while solai v reproduced the bug and verified that the revised patch removed the unwanted clause #5 #6.
- After testing restoration on PostgreSQL 14, 17, and master, shihao zhong recommended applying the change only to master because the extra clause did not affect restored rows #7.
- Fujii committed the revised patch unchanged apart from its base as cde33148c9 and confirmed that it landed on master only, completing the thread's proposed fix without backpatching #4 #8.