pg_restore --help
People,
In pg_restore --help I see this:
-O, --no-owner do not output commands to set object ownership
[...]
-x, --no-privileges skip restoration of access privileges (grant/revoke)
Do we talk about "output commands" to do things, or directly about
restoration? I think -O description should be
-O, --no-owner skip restoration of object ownership
or something similar, to be consistent. Patch for that attached, but
feel free to editorialize ...
--
Alvaro Herrera (<alvherre[a]dcc.uchile.cl>)
"The ability to monopolize a planet is insignificant
next to the power of the source"
Attachments:
restore.patchtext/plain; charset=us-asciiDownload
Index: src/bin/pg_dump/pg_restore.c
===================================================================
RCS file: /home/alvherre/cvs/pgsql/src/bin/pg_dump/pg_restore.c,v
retrieving revision 1.67
diff -c -r1.67 pg_restore.c
*** src/bin/pg_dump/pg_restore.c 27 Nov 2004 18:51:06 -0000 1.67
--- src/bin/pg_dump/pg_restore.c 3 Dec 2004 16:34:50 -0000
***************
*** 376,382 ****
printf(_(" -I, --index=NAME restore named index\n"));
printf(_(" -L, --use-list=FILENAME use specified table of contents for ordering\n"
" output from this file\n"));
! printf(_(" -O, --no-owner do not issue commands to set object ownership\n"));
printf(_(" -P, --function=NAME(args)\n"
" restore named function\n"));
printf(_(" -s, --schema-only restore only the schema, no data\n"));
--- 376,382 ----
printf(_(" -I, --index=NAME restore named index\n"));
printf(_(" -L, --use-list=FILENAME use specified table of contents for ordering\n"
" output from this file\n"));
! printf(_(" -O, --no-owner skip restoration of object ownership\n"));
printf(_(" -P, --function=NAME(args)\n"
" restore named function\n"));
printf(_(" -s, --schema-only restore only the schema, no data\n"));
On Fri, Dec 03, 2004 at 01:35:55PM -0300, Alvaro Herrera wrote:
In pg_restore --help I see this:
-O, --no-owner do not output commands to set object ownership
[...]
-x, --no-privileges skip restoration of access privileges (grant/revoke)
Sorry, of course the problem is not only pg_restore --no-owner, but also
in pg_dump and pg_dumpall as well (albeit with a slightly different
wording and meaning).
--
Alvaro Herrera (<alvherre[a]dcc.uchile.cl>)
"La espina, desde que nace, ya pincha" (Proverbio africano)
Alvaro Herrera <alvherre@dcc.uchile.cl> writes:
Do we talk about "output commands" to do things, or directly about
restoration? I think -O description should be
-O, --no-owner skip restoration of object ownership
This seems reasonable, but I wonder whether we should hold it for 8.1.
There hasn't been any official declaration that translatable strings
are frozen for 8.0 --- but are we at that point yet? Even if we're
not at hard freeze, minor wording improvements might be out.
Peter, I'll defer to your judgment on this ...
regards, tom lane
On Fri, Dec 03, 2004 at 12:20:51PM -0500, Tom Lane wrote:
This seems reasonable, but I wonder whether we should hold it for 8.1.
There hasn't been any official declaration that translatable strings
are frozen for 8.0 --- but are we at that point yet? Even if we're
not at hard freeze, minor wording improvements might be out.
Not sure, I've been holding translations precisely because strings are
not frozen yet ...
--
Alvaro Herrera (<alvherre[@]dcc.uchile.cl>)
"La virtud es el justo medio entre dos defectos" (Arist�teles)
Tom Lane wrote:
Alvaro Herrera <alvherre@dcc.uchile.cl> writes:
Do we talk about "output commands" to do things, or directly about
restoration? I think -O description should be
-O, --no-owner skip restoration of object ownershipThis seems reasonable, but I wonder whether we should hold it for
8.1. There hasn't been any official declaration that translatable
strings are frozen for 8.0 --- but are we at that point yet? Even if
we're not at hard freeze, minor wording improvements might be out.Peter, I'll defer to your judgment on this ...
Change it right now, and then we'll freeze. :)
--
Peter Eisentraut
http://developer.postgresql.org/~petere/