Call for port reports

ohp@pyrenet.fr wrote:

This did'nt get thru so I repost it!

8.0.0rc1 fails to compile on Unixware 714 with --enable-thread-safety :
CC=cc
LDFLAGS="-R/usr/local/lib"
ANT_HOME=/usr/local/jakarta/ant
JAVA_HOME=/usr/java2
PATH=$PATH:/usr/local/jakarta/ant/bin
#PREFIX="-prefix=/databases/pgsql-v7.4 --with-port=5532"
#DEBUG="--enable-debug --enable-cassert"
THREADS=--enable-thread-safety
export PATH CC ANT_HOME JAVA_HOME CPPFLAGS
./configure $PREFIX --enable-locale $DEBUG --with-ssl --with-perl --with-tcl --with-tk --enable-syslog --with-tclconfig=/usr/local/lib --with-tkconfig=/usr/local/lib --with-includes=/usr/local/include --with-libs=/usr/local/lib --with-java --without-CXX --without-x --with-ssl $THREADS
UX:acomp: ERREUR: "fe-secure.c", ligne 1316 : prototype mismatch: 2 args passed, 1 expected: sigwait()
gmake[3]: *** [fe-secure.o] Error 1
gmake[2]: *** [all] Error 2
gmake[1]: *** [all] Error 2
gmake: *** [all] Error 2
UX:make: ERREUR: erreur irr?m?diable.

It passes all tests without thread-safety.

What is your prototype for sigwait()?

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Bruce Momjian <pgman@candle.pha.pa.us> writes:

ohp@pyrenet.fr wrote:

UX:acomp: ERREUR: "fe-secure.c", ligne 1316 : prototype mismatch: 2 args passed, 1 expected: sigwait()

What is your prototype for sigwait()?

Whatever it is, it doesn't agree with the Single Unix Spec:
http://www.opengroup.org/onlinepubs/007908799/xsh/sigwait.html

On HPUX 10.20 I see

#include <pthread.h>

int sigwait(sigset_t *set);

and indeed --enable-thread-safety doesn't work on this platform,
although we fail the thread safety configure test so there are other
problems beside sigwait().

My feeling about this is "too bad, we are not supporting threading on
platforms whose pthread.h doesn't follow SUS".

regards, tom lane

Tom Lane wrote:

Bruce Momjian <pgman@candle.pha.pa.us> writes:

ohp@pyrenet.fr wrote:

UX:acomp: ERREUR: "fe-secure.c", ligne 1316 : prototype mismatch: 2 args passed, 1 expected: sigwait()

What is your prototype for sigwait()?

Whatever it is, it doesn't agree with the Single Unix Spec:
http://www.opengroup.org/onlinepubs/007908799/xsh/sigwait.html

On HPUX 10.20 I see

#include <pthread.h>

int sigwait(sigset_t *set);

and indeed --enable-thread-safety doesn't work on this platform,
although we fail the thread safety configure test so there are other
problems beside sigwait().

My feeling about this is "too bad, we are not supporting threading on
platforms whose pthread.h doesn't follow SUS".

I think we have to at least test for this in configure and give them an
error message there rather than generating a compile error later.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Bruce Momjian <pgman@candle.pha.pa.us> writes:

Tom Lane wrote:

My feeling about this is "too bad, we are not supporting threading on
platforms whose pthread.h doesn't follow SUS".

I think we have to at least test for this in configure and give them an
error message there rather than generating a compile error later.

No objection here --- feel free to extend the thread-safety test so that
it fails if sigwait has the wrong signature.

regards, tom lane

Prototype is

#include <signal.h>
int sigwait (sigset_t *set);

but fe_secure.c calls sigwait(&sigpipe_sigset, &signo);

so there's effectively one argument too much!
reards
On Fri, 17 Dec 2004, Tom Lane wrote:

Date: Fri, 17 Dec 2004 12:49:59 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <pgman@candle.pha.pa.us>
Cc: ohp@pyrenet.fr, pgsql-hackers list <pgsql-hackers@postgresql.org>
Subject: Re: [HACKERS] Call for port reports

Bruce Momjian <pgman@candle.pha.pa.us> writes:

ohp@pyrenet.fr wrote:

UX:acomp: ERREUR: "fe-secure.c", ligne 1316 : prototype mismatch: 2 args passed, 1 expected: sigwait()

What is your prototype for sigwait()?

Whatever it is, it doesn't agree with the Single Unix Spec:
http://www.opengroup.org/onlinepubs/007908799/xsh/sigwait.html

On HPUX 10.20 I see

#include <pthread.h>

int sigwait(sigset_t *set);

and indeed --enable-thread-safety doesn't work on this platform,
although we fail the thread safety configure test so there are other
problems beside sigwait().

My feeling about this is "too bad, we are not supporting threading on
platforms whose pthread.h doesn't follow SUS".

regards, tom lane

--
Olivier PRENANT Tel: +33-5-61-50-97-00 (Work)
6, Chemin d'Harraud Turrou +33-5-61-50-97-01 (Fax)
31190 AUTERIVE +33-6-07-63-80-64 (GSM)
FRANCE Email: ohp@pyrenet.fr
------------------------------------------------------------------------------
Make your life a dream, make your dream a reality. (St Exupery)