latest pgcrypto patches cause compile errors

Started by Stefan Kaltenbrunnerover 20 years ago9 messages

Stefan Kaltenbrunner

stefan@kaltenbrunner.cc

over 20 years ago

looks like the latest pgcrypto-patches that just got applied cause
widespread failures on the buildfarm machines:

http://www.pgbuildfarm.org/cgi-bin/show_status.pl

Stefan

Marko Kreen

marko@l-t.ee

over 20 years ago

In reply to: Stefan Kaltenbrunner (#1)

Re: latest pgcrypto patches cause compile errors

On Sun, Jul 10, 2005 at 10:59:35AM +0200, Stefan Kaltenbrunner wrote:

looks like the latest pgcrypto-patches that just got applied cause
widespread failures on the buildfarm machines:

http://www.pgbuildfarm.org/cgi-bin/show_status.pl

Seems like Bruce forgot to 'cvs add' new files...

--
marko

Bruce Momjian

pgman@candle.pha.pa.us

over 20 years ago

In reply to: Marko Kreen (#2)

Re: latest pgcrypto patches cause compile errors

Marko Kreen wrote:

On Sun, Jul 10, 2005 at 10:59:35AM +0200, Stefan Kaltenbrunner wrote:

looks like the latest pgcrypto-patches that just got applied cause
widespread failures on the buildfarm machines:

http://www.pgbuildfarm.org/cgi-bin/show_status.pl

Seems like Bruce forgot to 'cvs add' new files...

All new files added, and I think all the pgcrypto patches are now
applied to CVS. I just added the openssl version patch, I see the
IMMUTABLE patch is already in, and I see the autoconfiguration stuff is
already in.

Is there anything else outstanding for pgcrypto?

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Marko Kreen

marko@l-t.ee

over 20 years ago

In reply to: Bruce Momjian (#3)

Re: latest pgcrypto patches cause compile errors

On Sun, Jul 10, 2005 at 10:00:04AM -0400, Bruce Momjian wrote:

All new files added, and I think all the pgcrypto patches are now
applied to CVS. I just added the openssl version patch, I see the
IMMUTABLE patch is already in, and I see the autoconfiguration stuff is
already in.

Is there anything else outstanding for pgcrypto?

No, we are fully synched now.

That leaves only 2 things in my TODO list for 8.1:

- New documentation.
- I've spotted a few buggy comments in new code. Fix them.

--
marko

Marko Kreen

marko@l-t.ee

over 20 years ago

In reply to: Bruce Momjian (#3)

1 attachment(s)

Re: latest pgcrypto patches cause compile errors

On Sun, Jul 10, 2005 at 10:00:04AM -0400, Bruce Momjian wrote:

Marko Kreen wrote:

On Sun, Jul 10, 2005 at 10:59:35AM +0200, Stefan Kaltenbrunner wrote:

looks like the latest pgcrypto-patches that just got applied cause
widespread failures on the buildfarm machines:

http://www.pgbuildfarm.org/cgi-bin/show_status.pl

Seems like Bruce forgot to 'cvs add' new files...

All new files added, and I think all the pgcrypto patches are now
applied to CVS. I just added the openssl version patch, I see the
IMMUTABLE patch is already in, and I see the autoconfiguration stuff is
already in.

Is there anything else outstanding for pgcrypto?

I see from buildfarm, that pgcrypto fails to build on a
non-OpenSSL machine. The reason for it is a stale openssl/bn.h
include in pgp-pubdec.c. I did not spot it, as even for
--without-openssl build I still had OpenSSL intalled.

--
marko

Attachments:

hdrfix.difftext/plain; charset=us-asciiDownload

Index: contrib/pgcrypto/pgp-pubdec.c
===================================================================
RCS file: /projects/cvsroot/pgsql/contrib/pgcrypto/pgp-pubdec.c,v
retrieving revision 1.1
diff -c -r1.1 pgp-pubdec.c
*** contrib/pgcrypto/pgp-pubdec.c	10 Jul 2005 13:46:29 -0000	1.1
--- contrib/pgcrypto/pgp-pubdec.c	10 Jul 2005 15:28:26 -0000
***************
*** 30,37 ****
   */
  #include <postgres.h>
  
- #include <openssl/bn.h>
- 
  #include "px.h"
  #include "mbuf.h"
  #include "pgp.h"
--- 30,35 ----

Bruce Momjian

pgman@candle.pha.pa.us

over 20 years ago

In reply to: Marko Kreen (#5)

Re: latest pgcrypto patches cause compile errors

Marko Kreen wrote:

On Sun, Jul 10, 2005 at 10:00:04AM -0400, Bruce Momjian wrote:

Marko Kreen wrote:

On Sun, Jul 10, 2005 at 10:59:35AM +0200, Stefan Kaltenbrunner wrote:

looks like the latest pgcrypto-patches that just got applied cause
widespread failures on the buildfarm machines:

http://www.pgbuildfarm.org/cgi-bin/show_status.pl

Seems like Bruce forgot to 'cvs add' new files...

All new files added, and I think all the pgcrypto patches are now
applied to CVS. I just added the openssl version patch, I see the
IMMUTABLE patch is already in, and I see the autoconfiguration stuff is
already in.

Is there anything else outstanding for pgcrypto?

I see from buildfarm, that pgcrypto fails to build on a
non-OpenSSL machine. The reason for it is a stale openssl/bn.h
include in pgp-pubdec.c. I did not spot it, as even for
--without-openssl build I still had OpenSSL intalled.

Removed from CVS.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Marko Kreen

marko@l-t.ee

over 20 years ago

In reply to: Bruce Momjian (#6)

Re: latest pgcrypto patches cause compile errors

On Sun, Jul 10, 2005 at 11:37:22AM -0400, Bruce Momjian wrote:

Marko Kreen wrote:

I see from buildfarm, that pgcrypto fails to build on a
non-OpenSSL machine. The reason for it is a stale openssl/bn.h
include in pgp-pubdec.c. I did not spot it, as even for
--without-openssl build I still had OpenSSL intalled.

Removed from CVS.

One more failure:

http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=cicada&dt=2005-07-10%2017:39:18

I think this is because we don't have -lz in SHLIB_LINK.
Following patch fixes it.

--
marko

Marko Kreen

marko@l-t.ee

over 20 years ago

In reply to: Marko Kreen (#7)

1 attachment(s)

Re: latest pgcrypto patches cause compile errors

On Sun, Jul 10, 2005 at 09:10:29PM +0300, Marko Kreen wrote:

On Sun, Jul 10, 2005 at 11:37:22AM -0400, Bruce Momjian wrote:

Marko Kreen wrote:

I see from buildfarm, that pgcrypto fails to build on a
non-OpenSSL machine. The reason for it is a stale openssl/bn.h
include in pgp-pubdec.c. I did not spot it, as even for
--without-openssl build I still had OpenSSL intalled.

Removed from CVS.

One more failure:

http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=cicada&dt=2005-07-10%2017:39:18

I think this is because we don't have -lz in SHLIB_LINK.
Following patch fixes it.

Here's the patch.

--
marko

Attachments:

zfix.difftext/plain; charset=us-asciiDownload

Index: contrib/pgcrypto/Makefile
===================================================================
RCS file: /opt/arc/cvs2/pgsql/contrib/pgcrypto/Makefile,v
retrieving revision 1.20
diff -u -c -r1.20 Makefile
*** contrib/pgcrypto/Makefile	10 Jul 2005 03:57:55 -0000	1.20
--- contrib/pgcrypto/Makefile	10 Jul 2005 17:56:53 -0000
***************
*** 56,64 ****
  # Add libraries that pgcrypto depends (or might depend) on into the
  # shared library link.  (The order in which you list them here doesn't
  # matter.)
! SHLIB_LINK += $(filter -lcrypt -ldes -lcrypto -lssl, $(LIBS))
  ifeq ($(PORTNAME), win32)
! SHLIB_LINK += $(filter -leay32 -lssleay32, $(LIBS))
  endif
  
  # to make ws2_32.lib the last library (must occur after definition of PORTNAME)
--- 56,64 ----
  # Add libraries that pgcrypto depends (or might depend) on into the
  # shared library link.  (The order in which you list them here doesn't
  # matter.)
! SHLIB_LINK += $(filter -lcrypt -ldes -lcrypto -lssl -lz, $(LIBS))
  ifeq ($(PORTNAME), win32)
! SHLIB_LINK += $(filter -leay32 -lssleay32 -lz, $(LIBS))
  endif
  
  # to make ws2_32.lib the last library (must occur after definition of PORTNAME)

Bruce Momjian

pgman@candle.pha.pa.us

over 20 years ago

In reply to: Marko Kreen (#8)

Re: latest pgcrypto patches cause compile errors

Patch applied. Thanks.

---------------------------------------------------------------------------

Marko Kreen wrote:

On Sun, Jul 10, 2005 at 09:10:29PM +0300, Marko Kreen wrote:

On Sun, Jul 10, 2005 at 11:37:22AM -0400, Bruce Momjian wrote:

Marko Kreen wrote:

I see from buildfarm, that pgcrypto fails to build on a
non-OpenSSL machine. The reason for it is a stale openssl/bn.h
include in pgp-pubdec.c. I did not spot it, as even for
--without-openssl build I still had OpenSSL intalled.

Removed from CVS.

One more failure:

http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=cicada&dt=2005-07-10%2017:39:18

I think this is because we don't have -lz in SHLIB_LINK.
Following patch fixes it.

Here's the patch.

--
marko

[ Attachment, skipping... ]

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073