PostmasterHandl_patch of win32

Started by Hiroshi Saitoover 19 years ago3 messages
#1Hiroshi Saito
z-saito@guitar.ocn.ne.jp
1 attachment(s)

Hi Bruce-san.

Uga..., include is removed and it is out of order.....

pmsignal.c: In function `PostmasterIsAlive':
pmsignal.c:121: error: `PostmasterHandle' undeclared (first use in this function)
pmsignal.c:121: error: (Each undeclared identifier is reported only once
pmsignal.c:121: error: for each function it appears in.)
make[4]: *** [pmsignal.o] Error 1
make[3]: *** [ipc-recursive] Error 2
make[2]: *** [storage-recursive] Error 2
make[1]: *** [all] Error 2
make: *** [all] Error 2

Probably, this application will be required.
P.S)
In addition, there are some problems. It is corrected soon.

Regards,
Hiroshi Saito

Attachments:

PostmasterHandl_patchapplication/octet-stream; name=PostmasterHandl_patchDownload
--- src/backend/storage/ipc/pmsignal.c.orig	Sun Jul 16 08:40:14 2006
+++ src/backend/storage/ipc/pmsignal.c	Sun Jul 16 06:41:02 2006
@@ -21,6 +21,9 @@
 #include "storage/pmsignal.h"
 #include "storage/shmem.h"
 
+#ifdef WIN32
+extern HANDLE PostmasterHandle;
+#endif
 
 /*
  * The postmaster is signaled by its children by sending SIGUSR1.  The
--- src/include/postmaster/postmaster.h.orig	Sun Jul 16 08:40:14 2006
+++ src/include/postmaster/postmaster.h	Sun Jul 16 06:41:44 2006
@@ -30,10 +30,6 @@
 extern bool log_hostname;
 extern char *bonjour_name;
 
-#ifdef WIN32
-extern HANDLE PostmasterHandle;
-#endif
-
 extern const char *progname;
 
 extern int	PostmasterMain(int argc, char *argv[]);
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Hiroshi Saito (#1)
Re: PostmasterHandl_patch of win32

"Hiroshi Saito" <z-saito@guitar.ocn.ne.jp> writes:

Probably, this application will be required.

This seems very messy. The correct fix is just to put back the #include
line, no?

regards, tom lane

#3Hiroshi Saito
z-saito@guitar.ocn.ne.jp
In reply to: Hiroshi Saito (#1)
Re: PostmasterHandl_patch of win32

From: "Tom Lane"

"Hiroshi Saito" <z-saito@guitar.ocn.ne.jp> writes:

Probably, this application will be required.

This seems very messy. The correct fix is just to put back the #include
line, no?

@@ -18,6 +18,7 @@
#include <unistd.h>

#include "miscadmin.h"
+#include "postmaster/postmaster.h"
#include "storage/pmsignal.h"
#include "storage/shmem.h"

Ahh.., include by which you were committed is very good.
Thanks.!

Regards,
Hiroshi Saito