PostgreSQL v6.4 BETA2...

Started by Marc G. Fournierabout 27 years ago8 messages
#1Marc G. Fournier
scrappy@hub.org

Is now available, based on the source tree as of ~3am on Oct 15th.

With this BETA, the source code is frozen...there is *absolutely* no
changes to be made except that which is required to fix a bug that
pertains to the building and/or running on a particular platform, or to
fix a crucial bug.

If any BETA can stand, on its own, for 1 week, without a change being
required to the source code (docs don't count in this), then it will
become the released version.

Again, unless it is a *crucial* fix, please withhold all patches until
after we get this released and out to the public...

Marc G. Fournier scrappy@hub.org
Systems Administrator @ hub.org
scrappy@{postgresql|isc}.org ICQ#7615664

#2Noname
darcy@druid.net
In reply to: Marc G. Fournier (#1)
Re: [HACKERS] PostgreSQL v6.4 BETA2...

Thus spake Marc G. Fournier

With this BETA, the source code is frozen...there is *absolutely* no
changes to be made except that which is required to fix a bug that
pertains to the building and/or running on a particular platform, or to
fix a crucial bug.

What about the inet stuff. I'm just waiting for Paul's inet_cidr*
functions to test and submit the final stuff. As it stand it will
crash the backend if you use it. I guess that makes it a bug fix,
right?

I'll submit the builtins.h changes in the meantime. Perhaps I can
cobble up my own version of the inet_cidr* functions at least to
be able to test my functions.

-- 
D'Arcy J.M. Cain <darcy@{druid|vex}.net>   |  Democracy is three wolves
http://www.druid.net/darcy/                |  and a sheep voting on
+1 416 424 2871     (DoD#0082)    (eNTP)   |  what's for dinner.
#3Andreas Zeugswetter
andreas.zeugswetter@telecom.at
In reply to: Noname (#2)
AW: [HACKERS] PostgreSQL v6.4 BETA2...

The problem is probably that the functions incorrectly return text *
but use it like char *. text * is a varlena

e.g. text *inet_netmask in inet.c
eighter must be char *inet_netmask or correctly use macros VARDATA and VARSIZE

Andreas

----------
Von: D'Arcy J.M. Cain[SMTP:darcy@druid.net]
Gesendet: Donnerstag, 15. Oktober 1998 13:54
An: Marc G. Fournier
Cc: pgsql-hackers@postgreSQL.org
Betreff: Re: [HACKERS] PostgreSQL v6.4 BETA2...

Thus spake Marc G. Fournier

With this BETA, the source code is frozen...there is *absolutely* no
changes to be made except that which is required to fix a bug that
pertains to the building and/or running on a particular platform, or to
fix a crucial bug.

What about the inet stuff. I'm just waiting for Paul's inet_cidr*
functions to test and submit the final stuff. As it stand it will
crash the backend if you use it. I guess that makes it a bug fix,
right?

I'll submit the builtins.h changes in the meantime. Perhaps I can
cobble up my own version of the inet_cidr* functions at least to
be able to test my functions.

-- 
D'Arcy J.M. Cain <darcy@{druid|vex}.net>   |  Democracy is three wolves
http://www.druid.net/darcy/                |  and a sheep voting on
+1 416 424 2871     (DoD#0082)    (eNTP)   |  what's for dinner.
#4Marc G. Fournier
scrappy@hub.org
In reply to: Noname (#2)
Re: [HACKERS] PostgreSQL v6.4 BETA2...

On Thu, 15 Oct 1998, D'Arcy J.M. Cain wrote:

Thus spake Marc G. Fournier

With this BETA, the source code is frozen...there is *absolutely* no
changes to be made except that which is required to fix a bug that
pertains to the building and/or running on a particular platform, or to
fix a crucial bug.

What about the inet stuff. I'm just waiting for Paul's inet_cidr*
functions to test and submit the final stuff. As it stand it will
crash the backend if you use it. I guess that makes it a bug fix,
right?

But of course :) Anything that affects the backend, especially
something that can relatively easily reproduce a crash, is a definite bug
that needs to be fixed...

Marc G. Fournier scrappy@hub.org
Systems Administrator @ hub.org
scrappy@{postgresql|isc}.org ICQ#7615664

#5Noname
darcy@druid.net
In reply to: Andreas Zeugswetter (#3)
Re: AW: [HACKERS] PostgreSQL v6.4 BETA2...

Thus spake Andreas Zeugswetter

The problem is probably that the functions incorrectly return text *
but use it like char *. text * is a varlena

Yes, Bruce explained the change but I don't want to submit patches now
until the other functions have been added and I can test the module.

-- 
D'Arcy J.M. Cain <darcy@{druid|vex}.net>   |  Democracy is three wolves
http://www.druid.net/darcy/                |  and a sheep voting on
+1 416 424 2871     (DoD#0082)    (eNTP)   |  what's for dinner.
#6Bruce Momjian
maillist@candle.pha.pa.us
In reply to: Noname (#2)
Re: [HACKERS] PostgreSQL v6.4 BETA2...

Thus spake Marc G. Fournier

With this BETA, the source code is frozen...there is *absolutely* no
changes to be made except that which is required to fix a bug that
pertains to the building and/or running on a particular platform, or to
fix a crucial bug.

What about the inet stuff. I'm just waiting for Paul's inet_cidr*
functions to test and submit the final stuff. As it stand it will
crash the backend if you use it. I guess that makes it a bug fix,
right?

I like your thinking.

I'll submit the builtins.h changes in the meantime. Perhaps I can
cobble up my own version of the inet_cidr* functions at least to
be able to test my functions.

Just wait and submit the whole thing. It is more likely to work in that
case.

Yes, I think that will have to be slipped in. Hope Marc agrees.

-- 
  Bruce Momjian                        |  http://www.op.net/~candle
  maillist@candle.pha.pa.us            |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
#7Bruce Momjian
maillist@candle.pha.pa.us
In reply to: Andreas Zeugswetter (#3)
Re: AW: [HACKERS] PostgreSQL v6.4 BETA2...

The problem is probably that the functions incorrectly return text *
but use it like char *. text * is a varlena

e.g. text *inet_netmask in inet.c
eighter must be char *inet_netmask or correctly use macros VARDATA and VARSIZE

No, they are missing sections as we wait for additional inet functions.

-- 
  Bruce Momjian                        |  http://www.op.net/~candle
  maillist@candle.pha.pa.us            |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
#8Noname
darcy@druid.net
In reply to: Bruce Momjian (#6)
Re: [HACKERS] PostgreSQL v6.4 BETA2...

Thus spake Bruce Momjian

I'll submit the builtins.h changes in the meantime. Perhaps I can
cobble up my own version of the inet_cidr* functions at least to
be able to test my functions.

Just wait and submit the whole thing. It is more likely to work in that
case.

Sure. I meant that I would cobble up a rough approximation of the
functions locally just so I could test my stuff. I'm still waiting
for Paul to build the real ones.

-- 
D'Arcy J.M. Cain <darcy@{druid|vex}.net>   |  Democracy is three wolves
http://www.druid.net/darcy/                |  and a sheep voting on
+1 416 424 2871     (DoD#0082)    (eNTP)   |  what's for dinner.