Documentation fix for --with-ldap

Started by Albe Laurenzover 19 years ago8 messages
#1Albe Laurenz
all@adv.magwien.gv.at
1 attachment(s)

This is just a 'one line' change in the documentation of
the --with-ldap flag of ./configure

Yours,
Laurenz Albe

Attachments:

ldapdoc.patchapplication/octet-stream; name=ldapdoc.patchDownload
diff -r -c pgsql.orig/doc/src/sgml/installation.sgml pgsql/doc/src/sgml/installation.sgml
*** pgsql.orig/doc/src/sgml/installation.sgml	2006-08-21 10:41:03.000000000 +0200
--- pgsql/doc/src/sgml/installation.sgml	2006-09-04 10:14:30.000000000 +0200
***************
*** 854,860 ****
         <listitem>
          <para>
           Build with <acronym>LDAP</><indexterm><primary>LDAP</></>
!          authentication support. On Unix, this requires the
           <productname>OpenLDAP</> package to be installed.
           <filename>configure</> will check for the required header files
           and libraries to make sure that your <productname>OpenLDAP</>
--- 854,866 ----
         <listitem>
          <para>
           Build with <acronym>LDAP</><indexterm><primary>LDAP</></>
!          support for authentication and connection parameter
!          lookup (see
!          <![%standalone-include[the documentation about
!           client authentication and libpq]]>
!          <![%standalone-ignore[<xref linkend="libpq-ldap">
!           and <xref linkend="auth-ldap">]]>
!          for more information). On Unix, this requires the
           <productname>OpenLDAP</> package to be installed.
           <filename>configure</> will check for the required header files
           and libraries to make sure that your <productname>OpenLDAP</>
#2Peter Eisentraut
peter_e@gmx.net
In reply to: Albe Laurenz (#1)
Re: [PATCHES] Documentation fix for --with-ldap

Am Montag, 4. September 2006 10:23 schrieb Albe Laurenz:

This is just a 'one line' change in the documentation of
the --with-ldap flag of ./configure

Well, if you want to link from the configure option to the place where the
feature is explained, then that should be done consistently for all options.
That might bloat the installation instructions, though. Not sure.

--
Peter Eisentraut
http://developer.postgresql.org/~petere/

#3Albe Laurenz
all@adv.magwien.gv.at
In reply to: Peter Eisentraut (#2)
Re: [PATCHES] Documentation fix for --with-ldap

Peter Eisentraut wrote:

Am Montag, 4. September 2006 10:23 schrieb Albe Laurenz:

This is just a 'one line' change in the documentation of
the --with-ldap flag of ./configure

Well, if you want to link from the configure option to the place where

the

feature is explained, then that should be done consistently for all

options.

That might bloat the installation instructions, though. Not sure.

I didn't think of that.
Originally, all I wanted to do is change the wording from

"Build with LDAP authentication support."

to

"Build with LDAP support for authentication and connection parameter
lookup."

Then I thought it might be nice to add links.
But I don't think it is important.

Yours,
Laurenz Albe

#4Bruce Momjian
bruce@momjian.us
In reply to: Albe Laurenz (#3)
1 attachment(s)
Re: [PATCHES] Documentation fix for --with-ldap

Albe Laurenz wrote:

Peter Eisentraut wrote:

Am Montag, 4. September 2006 10:23 schrieb Albe Laurenz:

This is just a 'one line' change in the documentation of
the --with-ldap flag of ./configure

Well, if you want to link from the configure option to the place where

the

feature is explained, then that should be done consistently for all

options.

That might bloat the installation instructions, though. Not sure.

I didn't think of that.
Originally, all I wanted to do is change the wording from

"Build with LDAP authentication support."

to

"Build with LDAP support for authentication and connection parameter
lookup."

Then I thought it might be nice to add links.
But I don't think it is important.

More limited modification you mentioned added to documentation.

--
Bruce Momjian bruce@momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Attachments:

/rtmp/difftext/x-diffDownload
Index: doc/src/sgml/installation.sgml
===================================================================
RCS file: /cvsroot/pgsql/doc/src/sgml/installation.sgml,v
retrieving revision 1.260
diff -c -c -r1.260 installation.sgml
*** doc/src/sgml/installation.sgml	17 Aug 2006 17:25:43 -0000	1.260
--- doc/src/sgml/installation.sgml	4 Sep 2006 21:42:13 -0000
***************
*** 853,860 ****
         <term><option>--with-ldap</option></term>
         <listitem>
          <para>
!          Build with <acronym>LDAP</><indexterm><primary>LDAP</></>
!          authentication support. On Unix, this requires the
           <productname>OpenLDAP</> package to be installed.
           <filename>configure</> will check for the required header files
           and libraries to make sure that your <productname>OpenLDAP</>
--- 853,861 ----
         <term><option>--with-ldap</option></term>
         <listitem>
          <para>
!          Build with <acronym>LDAP</><indexterm><primary>LDAP</></> support
!          for authentication and connection parameter lookup.
!          On Unix, this requires the
           <productname>OpenLDAP</> package to be installed.
           <filename>configure</> will check for the required header files
           and libraries to make sure that your <productname>OpenLDAP</>
#5Neil Conway
neilc@samurai.com
In reply to: Albe Laurenz (#1)
Re: Documentation fix for --with-ldap

On Mon, 2006-09-04 at 10:23 +0200, Albe Laurenz wrote:

This is just a 'one line' change in the documentation of
the --with-ldap flag of ./configure

Applied, thanks for the patch.

(BTW, when trivial patches like this fall through the cracks, I'd
encourage patch submitters to resend them if you'd like to see them
applied more promptly.)

-Neil

#6Peter Eisentraut
peter_e@gmx.net
In reply to: Neil Conway (#5)
Re: [PATCHES] Documentation fix for --with-ldap

Neil Conway wrote:

On Mon, 2006-09-04 at 10:23 +0200, Albe Laurenz wrote:

This is just a 'one line' change in the documentation of
the --with-ldap flag of ./configure

Applied, thanks for the patch.

(BTW, when trivial patches like this fall through the cracks, I'd
encourage patch submitters to resend them if you'd like to see them
applied more promptly.)

Actually the patch was previously rejected.

--
Peter Eisentraut
http://developer.postgresql.org/~petere/

#7Neil Conway
neilc@samurai.com
In reply to: Peter Eisentraut (#6)
Re: [PATCHES] Documentation fix for --with-ldap

On Thu, 2006-10-12 at 21:11 +0200, Peter Eisentraut wrote:

Actually the patch was previously rejected.

Oh? Sorry, I must have missed that. On what grounds was it rejected?

-Neil

#8Albe Laurenz
all@adv.magwien.gv.at
In reply to: Neil Conway (#7)
Re: [PATCHES] Documentation fix for --with-ldap

Actually the patch was previously rejected.

Oh? Sorry, I must have missed that. On what grounds was it rejected?

Because it was decided that hyperlinks are undesirable in this place.
Instead, a simpler version of the patch was applied.

See
http://archives.postgresql.org/pgsql-hackers/2006-09/msg00383.php

Yours, and thanks,
Laurenz Albe