pg_strcasecmp in fe-connect.c

Started by Magnus Haganderover 19 years ago4 messageshackers
Jump to latest
#1Magnus Hagander
magnus@hagander.net

This patch fixes a couple of cases where we use strcasecmp() instead of
pg_strcasecmp() in fe_connect.c, coming from the LDAP client pathc.

//Magnu <<libpq_strcmp.diff>> s

Attachments:

libpq_strcmp.diffapplication/octet-stream; name=libpq_strcmp.diffDownload+8-8
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Magnus Hagander (#1)
Re: pg_strcasecmp in fe-connect.c

"Magnus Hagander" <mha@sollentuna.net> writes:

This patch fixes a couple of cases where we use strcasecmp() instead of
pg_strcasecmp() in fe_connect.c, coming from the LDAP client pathc.

Applied. I found another instance in contrib/hstore, too. There are
also some occurrences in pgbench.c, but I'm unsure that we need be
paranoid about changing those.

regards, tom lane

#3Magnus Hagander
magnus@hagander.net
In reply to: Tom Lane (#2)
Re: [PATCHES] pg_strcasecmp in fe-connect.c

This patch fixes a couple of cases where we use

strcasecmp() instead

of
pg_strcasecmp() in fe_connect.c, coming from the LDAP client pathc.

Applied. I found another instance in contrib/hstore, too.

Ah. msvc builds don't currently build /contrib, that's why I missed that
one.

There are also some occurrences in pgbench.c, but I'm unsure
that we need be paranoid about changing those.

If we ever want to be able to compile it on a platform that doesn't have
strcasecmp() (such as MSVC++), we would, no?

//Magnus

#4Tom Lane
tgl@sss.pgh.pa.us
In reply to: Magnus Hagander (#3)
Re: [PATCHES] pg_strcasecmp in fe-connect.c

"Magnus Hagander" <mha@sollentuna.net> writes:

There are also some occurrences in pgbench.c, but I'm unsure
that we need be paranoid about changing those.

If we ever want to be able to compile it on a platform that doesn't have
strcasecmp() (such as MSVC++), we would, no?

OK, replaced 'em all.

regards, tom lane