qsort_arg needed for msvc build

Started by Magnus Haganderover 19 years ago4 messages
#1Magnus Hagander
mha@sollentuna.net
1 attachment(s)

See attached patch.

//Magnus

Attachments:

msvc_qsort.diffapplication/octet-stream; name=msvc_qsort.diffDownload
Index: src\tools\msvc/mkvcbuild.pl
===================================================================
RCS file: c:/prog/cvsrepo/pgsql/pgsql/src/tools/msvc/mkvcbuild.pl,v
retrieving revision 1.4
diff -c -r1.4 mkvcbuild.pl
*** src\tools\msvc/mkvcbuild.pl	3 Oct 2006 22:12:14 -0000	1.4
--- src\tools\msvc/mkvcbuild.pl	4 Oct 2006 11:58:34 -0000
***************
*** 18,25 ****
     crypt.c fseeko.c getrusage.c inet_aton.c random.c srandom.c
     unsetenv.c getaddrinfo.c gettimeofday.c kill.c open.c rand.c
     snprintf.c strlcpy.c copydir.c dirmod.c exec.c noblock.c path.c pipe.c
!    pgsleep.c pgstrcasecmp.c sprompt.c thread.c getopt.c getopt_long.c
!    dirent.c rint.c win32error.c);
  
  my $libpgport = $solution->AddProject('libpgport','lib','misc');
  $libpgport->AddDefine('FRONTEND');
--- 18,25 ----
     crypt.c fseeko.c getrusage.c inet_aton.c random.c srandom.c
     unsetenv.c getaddrinfo.c gettimeofday.c kill.c open.c rand.c
     snprintf.c strlcpy.c copydir.c dirmod.c exec.c noblock.c path.c pipe.c
!    pgsleep.c pgstrcasecmp.c qsort_arg.c sprompt.c thread.c 
!    getopt.c getopt_long.c dirent.c rint.c win32error.c);
  
  my $libpgport = $solution->AddProject('libpgport','lib','misc');
  $libpgport->AddDefine('FRONTEND');
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Magnus Hagander (#1)
Re: qsort_arg needed for msvc build

"Magnus Hagander" <mha@sollentuna.net> writes:

See attached patch.

Grumble. That's going to be a continuing maintenance pain, isn't it?
We need to find a way to extract the list from the src/port Makefile.

regards, tom lane

#3Magnus Hagander
mha@sollentuna.net
In reply to: Tom Lane (#2)
Re: [PATCHES] qsort_arg needed for msvc build

See attached patch.

Grumble. That's going to be a continuing maintenance pain, isn't
it?
We need to find a way to extract the list from the src/port
Makefile.

Well, it's platform dependent as it's set from configure, no?

I guess we could pull the "use on all platforms" set, and then just
append win32 specific ones, that should help a bit? If there is such a
list (don't have the code around right now) to read from.

//Magnus

#4Tom Lane
tgl@sss.pgh.pa.us
In reply to: Magnus Hagander (#3)
Re: [PATCHES] qsort_arg needed for msvc build

"Magnus Hagander" <mha@sollentuna.net> writes:

I guess we could pull the "use on all platforms" set, and then just
append win32 specific ones, that should help a bit? If there is such a
list (don't have the code around right now) to read from.

That would probably help. Currently the "all platforms" list is in
Makefile.global.in (part of the setup of $(LIBOBJ)), which is itself
a pretty crufty thing. Not sure where better to put it though.

regards, tom lane