qsort_arg needed for msvc build

Started by Magnus Haganderover 19 years ago4 messageshackers
Jump to latest
#1Magnus Hagander
magnus@hagander.net

See attached patch.

//Magnus

Attachments:

msvc_qsort.diffapplication/octet-stream; name=msvc_qsort.diffDownload+4-4
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Magnus Hagander (#1)
Re: qsort_arg needed for msvc build

"Magnus Hagander" <mha@sollentuna.net> writes:

See attached patch.

Grumble. That's going to be a continuing maintenance pain, isn't it?
We need to find a way to extract the list from the src/port Makefile.

regards, tom lane

#3Magnus Hagander
magnus@hagander.net
In reply to: Tom Lane (#2)
Re: [PATCHES] qsort_arg needed for msvc build

See attached patch.

Grumble. That's going to be a continuing maintenance pain, isn't
it?
We need to find a way to extract the list from the src/port
Makefile.

Well, it's platform dependent as it's set from configure, no?

I guess we could pull the "use on all platforms" set, and then just
append win32 specific ones, that should help a bit? If there is such a
list (don't have the code around right now) to read from.

//Magnus

#4Tom Lane
tgl@sss.pgh.pa.us
In reply to: Magnus Hagander (#3)
Re: [PATCHES] qsort_arg needed for msvc build

"Magnus Hagander" <mha@sollentuna.net> writes:

I guess we could pull the "use on all platforms" set, and then just
append win32 specific ones, that should help a bit? If there is such a
list (don't have the code around right now) to read from.

That would probably help. Currently the "all platforms" list is in
Makefile.global.in (part of the setup of $(LIBOBJ)), which is itself
a pretty crufty thing. Not sure where better to put it though.

regards, tom lane