savepoints and upgrading locks

Started by Jeff Davisover 18 years ago5 messages
#1Jeff Davis
pgsql@j-davis.com

This thread here became a TODO item:

http://archives.postgresql.org/pgsql-hackers/2006-11/msg01011.php

During that discussion a patch was produced that nobody seemed to have
objections to. The main problem seemed to be that it wouldn't always
downgrade the lock on a ROLLBACK TO (as I understand it), which doesn't
seem like a problem to me.

Is there a reason this isn't a part of 8.3, or was it just forgotten?

Regards,
Jeff Davis

#2Bruce Momjian
bruce@momjian.us
In reply to: Jeff Davis (#1)
Re: savepoints and upgrading locks

Your patch has been added to the PostgreSQL unapplied patches list at:

http://momjian.postgresql.org/cgi-bin/pgpatches

It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.

---------------------------------------------------------------------------

Jeff Davis wrote:

This thread here became a TODO item:

http://archives.postgresql.org/pgsql-hackers/2006-11/msg01011.php

During that discussion a patch was produced that nobody seemed to have
objections to. The main problem seemed to be that it wouldn't always
downgrade the lock on a ROLLBACK TO (as I understand it), which doesn't
seem like a problem to me.

Is there a reason this isn't a part of 8.3, or was it just forgotten?

Regards,
Jeff Davis

---------------------------(end of broadcast)---------------------------
TIP 4: Have you searched our list archives?

http://archives.postgresql.org

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

#3Alvaro Herrera
alvherre@commandprompt.com
In reply to: Bruce Momjian (#2)
Re: savepoints and upgrading locks

Bruce Momjian wrote:

Your patch has been added to the PostgreSQL unapplied patches list at:

http://momjian.postgresql.org/cgi-bin/pgpatches

It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.

Wait a minute. Would the mentioned patch be this one?
http://article.gmane.org/gmane.comp.db.postgresql.devel.general/73330

Because it was later declared not working; see
http://article.gmane.org/gmane.comp.db.postgresql.devel.general/73334

Jeff Davis wrote:

This thread here became a TODO item:

http://archives.postgresql.org/pgsql-hackers/2006-11/msg01011.php

During that discussion a patch was produced that nobody seemed to have
objections to. The main problem seemed to be that it wouldn't always
downgrade the lock on a ROLLBACK TO (as I understand it), which doesn't
seem like a problem to me.

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

#4Tom Lane
tgl@sss.pgh.pa.us
In reply to: Bruce Momjian (#2)
Re: savepoints and upgrading locks

Bruce Momjian <bruce@momjian.us> writes:

Your patch has been added to the PostgreSQL unapplied patches list at:

Please take it off again.

Jeff Davis wrote:

This thread here became a TODO item:
http://archives.postgresql.org/pgsql-hackers/2006-11/msg01011.php

During that discussion a patch was produced that nobody seemed to have
objections to.

Apparently you stopped reading somewhere. It was pretty thoroughly
destroyed beginning here:
http://archives.postgresql.org/pgsql-hackers/2006-12/msg00025.php

We should have spent more effort trying to think of a solution to the
problem during the 8.3 development cycle. At the moment we're no
further ahead than we were in December.

regards, tom lane

#5Bruce Momjian
bruce@momjian.us
In reply to: Tom Lane (#4)
Re: savepoints and upgrading locks

OK, emails moved to 8.4 queue.

---------------------------------------------------------------------------

Tom Lane wrote:

Bruce Momjian <bruce@momjian.us> writes:

Your patch has been added to the PostgreSQL unapplied patches list at:

Please take it off again.

Jeff Davis wrote:

This thread here became a TODO item:
http://archives.postgresql.org/pgsql-hackers/2006-11/msg01011.php

During that discussion a patch was produced that nobody seemed to have
objections to.

Apparently you stopped reading somewhere. It was pretty thoroughly
destroyed beginning here:
http://archives.postgresql.org/pgsql-hackers/2006-12/msg00025.php

We should have spent more effort trying to think of a solution to the
problem during the 8.3 development cycle. At the moment we're no
further ahead than we were in December.

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 5: don't forget to increase your free space map settings

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +