compiler warnings in ecpglib/execute.c (uninitialized local variable 'prepname' used)
while rebuilding pgsql with msvc 2005 I noticed this compiler warning:
.\src\interfaces\ecpg\ecpglib\execute.c(1495): warning C4700:
uninitialized local variable 'prepname' used
ECPGfree(prepname) is called in line 1495, prepname was not
unitialized befor. Below the line 1495 ECPGfree(prepname) is not
called in the function ECPGdo. I didn't investigate the code in
detail, but I assume that at least in some error conditions (when the
function returns false?) ECPGfree(prepname) should be called.
-Hannes
On Thu, Sep 20, 2007 at 02:05:57PM +0200, Hannes Eder wrote:
while rebuilding pgsql with msvc 2005 I noticed this compiler warning:
.\src\interfaces\ecpg\ecpglib\execute.c(1495): warning C4700: uninitialized
local variable 'prepname' used
This free() call seems to be absolutely superfluous, so I removed it.
Fixed in CVS head.
Thanks for the report.
Michael
--
Michael Meskes
Email: Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: meskes@jabber.org
Go SF 49ers! Go Rhein Fire! Use Debian GNU/Linux! Use PostgreSQL!