pgsql: Some cleanups of enum-guc code, per comments from Tom.
Log Message:
-----------
Some cleanups of enum-guc code, per comments from Tom.
Modified Files:
--------------
pgsql/src/backend/utils/misc:
README (r1.8 -> r1.9)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/README?r1=1.8&r2=1.9)
guc.c (r1.437 -> r1.438)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/guc.c?r1=1.437&r2=1.438)
pgsql/src/include/utils:
guc.h (r1.91 -> r1.92)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/utils/guc.h?r1=1.91&r2=1.92)
guc_tables.h (r1.39 -> r1.40)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/utils/guc_tables.h?r1=1.39&r2=1.40)
Magnus Hagander wrote:
Log Message:
-----------
Some cleanups of enum-guc code, per comments from Tom.
These bits seem to have broken --describe-config:
LC_ALL=C postmaster --describe-config > /dev/null
internal error: unrecognized run-time parameter type
internal error: unrecognized run-time parameter type
internal error: unrecognized run-time parameter type
internal error: unrecognized run-time parameter type
internal error: unrecognized run-time parameter type
(Perhaps they were already broken in the previous patch, not sure).
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
Alvaro Herrera <alvherre@commandprompt.com> writes:
These bits seem to have broken --describe-config:
(Perhaps they were already broken in the previous patch, not sure).
It was already broken :-(. Not sure how both Magnus and I missed
the switch in help_config.c --- I know I grepped for references to
the PGC_xxx enum constants, and I suppose he did too.
regards, tom lane
Tom Lane wrote:
Alvaro Herrera <alvherre@commandprompt.com> writes:
These bits seem to have broken --describe-config:
(Perhaps they were already broken in the previous patch, not sure).It was already broken :-(. Not sure how both Magnus and I missed
the switch in help_config.c --- I know I grepped for references to
the PGC_xxx enum constants, and I suppose he did too.
Yeah, that's what I did, and I have no idea how I missed it.
Will fix.
//Magnus