numeric_big test

Started by Peter Eisentrautover 17 years ago2 messages
#1Peter Eisentraut
peter_e@gmx.net

The numeric_big regression test was added many years ago for the NUMERIC
implementation but was not put in the default test set because it was
too slow. Now my tests show, it is really not slower than some of the
other slow tests (e.g., stats, tablespace), so perhaps time has caught
up with us and we can now test it by default.

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Peter Eisentraut (#1)
Re: numeric_big test

Peter Eisentraut <peter_e@gmx.net> writes:

The numeric_big regression test was added many years ago for the NUMERIC
implementation but was not put in the default test set because it was
too slow. Now my tests show, it is really not slower than some of the
other slow tests (e.g., stats, tablespace), so perhaps time has caught
up with us and we can now test it by default.

The other side of the coin is what would it possibly tell us that is
worth any extra cycles at all? We do run it (at least I do) when
touching the numeric datatype. Given the lack of machine dependence in
that code, it seems unlikely that running numeric_big at other times
would turn up anything. I can't see that it's worth slowing down
everyone's regression tests for.

(As somebody who frequently runs the regression tests dozens of times a
day, I grudge any unnecessarily expensive testing...)

regards, tom lane