Fixed outfuncs

Started by Nonameabout 27 years ago2 messages
#1Noname
jwieck@debis.com

Hi,

just committed some fixes to get back the old "<>" for NULL
strings on nodeToString().

Marc's recent changes to appendStringInfo() handling broke
it. The old version converted a NULL string into a "<>".
Handing a NULL for %s to vsnprintf() is implementation
dependent (some put nothing, some put (null) and some might
simply crash - but none puts "<>").

There is a new macro stringStringInfo(s) in include/lib.h
which checks for NULL and substitutes by "<>". All string
arguments to appendStringInfo() are now embedded into that
(also in commands/explain.c).

Regression tests for select_views, rules and plpgsql are O.K.
again.

Jan

--

#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me. #
#======================================== jwieck@debis.com (Jan Wieck) #

#2Keith Parks
emkxp01@mtcc.demon.co.uk
In reply to: Noname (#1)
Re: [HACKERS] Fixed outfuncs

Jan,

Thanks for this, I'm happy now :-)

Regression tests all pass except for a couple of
"non functional update" messages in misc.

Great job,
Keith.

jwieck@debis.com (Jan Wieck)

Show quoted text

Hi,

just committed some fixes to get back the old "<>" for NULL
strings on nodeToString().