Error arguments in pl_exec.c

Started by Magnus Haganderover 17 years ago4 messageshackers
Jump to latest
#1Magnus Hagander
magnus@hagander.net

I get the following warnings in HEAD

pl_exec.c: In function ‘exec_stmt_raise’:
pl_exec.c:2538: warning: format not a string literal and no format arguments
pl_exec.c:2538: warning: format not a string literal and no format arguments

Attached patch seems right to me - objections?

//Magnus

Attachments:

plexec.difftext/x-diff; name=plexec.diffDownload+4-4
#2Bruce Momjian
bruce@momjian.us
In reply to: Magnus Hagander (#1)
Re: Error arguments in pl_exec.c

Magnus Hagander <magnus@hagander.net> writes:

I get the following warnings in HEAD

pl_exec.c: In function ‘exec_stmt_raise’:
pl_exec.c:2538: warning: format not a string literal and no format arguments
pl_exec.c:2538: warning: format not a string literal and no format arguments

Attached patch seems right to me - objections?

ick. that's actually a security hole. Thankfully it's new code in cvs head.

--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com
Ask me about EnterpriseDB's Slony Replication support!

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Magnus Hagander (#1)
Re: Error arguments in pl_exec.c

Magnus Hagander <magnus@hagander.net> writes:

Attached patch seems right to me - objections?

Good catch. What gave you these warnings exactly?

regards, tom lane

#4Magnus Hagander
magnus@hagander.net
In reply to: Tom Lane (#3)
Re: Error arguments in pl_exec.c

Tom Lane wrote:

Magnus Hagander <magnus@hagander.net> writes:

Attached patch seems right to me - objections?

Good catch. What gave you these warnings exactly?

Same here - the new version of gcc.

Will go ahead and apply.

//Magnus