A question for the patch "blooming filter"

Started by Unicronabout 17 years ago2 messages
#1Unicron
ssmei_2000@yahoo.com

i have a view of code, and find a question.There is a variable named 'bloom_pruning" set to be
'false' outside function 'bloom_filter_init' in file 'bloomfn.c', and there is a stataments
if (bloom_pruning == false)
   return;
at begin of the function "bloom_filter_init".

And i don't find  any places which set variable 'bloom_pruning' to 'true', may i take it as
code following the statments above in 'bloom_filter_init' never execute?

#2Fujii Masao
masao.fujii@gmail.com
In reply to: Unicron (#1)
Re: A question for the patch "blooming filter"

Hi,

On Wed, Dec 10, 2008 at 10:02 AM, Unicron <ssmei_2000@yahoo.com> wrote:

i have a view of code, and find a question.There is a variable named
'bloom_pruning" set to be
'false' outside function 'bloom_filter_init' in file 'bloomfn.c', and there
is a stataments
if (bloom_pruning == false)
return;
at begin of the function "bloom_filter_init".

And i don't find any places which set variable 'bloom_pruning' to 'true',
may i take it as
code following the statments above in 'bloom_filter_init' never execute?

bloom_pruning is GUC, so it's set to true/false when postgresql.conf
is parsed or SET command is executed.

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center