pg_restore --clean text

Started by Erik Rijkersover 17 years ago4 messageshackers
Jump to latest
#1Erik Rijkers
er@xs4all.nl

The help text for the pg_restore --clean option in the documentation is IMHO more precise than the
text that the pg_restore binary gives:

documentation:
-c
--clean
Clean (drop) database objects before recreating them.

pg_restore binary:
-c, --clean clean (drop) schema prior to create

So I think it would be an improvement to channge the pg_restore --help text:

*** src/bin/pg_dump/pg_restore.c.orig   2008-12-27 01:16:23.000000000 +0100
--- src/bin/pg_dump/pg_restore.c        2008-12-27 01:29:53.000000000 +0100
***************
*** 385,391 ****
        printf(_("\nOptions controlling the restore:\n"));
        printf(_("  -a, --data-only          restore only the data, no schema\n"));
!       printf(_("  -c, --clean              clean (drop) schema prior to create\n"));
        printf(_("  -C, --create             create the target database\n"));
        printf(_("  -I, --index=NAME         restore named index\n"));
        printf(_("  -L, --use-list=FILENAME  use specified table of contents for ordering\n"
--- 385,391 ----

printf(_("\nOptions controlling the restore:\n"));
printf(_(" -a, --data-only restore only the data, no schema\n"));
! printf(_(" -c, --clean clean (drop) database objects prior to creating
them\n"));
printf(_(" -C, --create create the target database\n"));
printf(_(" -I, --index=NAME restore named index\n"));
printf(_(" -L, --use-list=FILENAME use specified table of contents for ordering\n"

thanks,

Erik Rijkers

#2Bruce Momjian
bruce@momjian.us
In reply to: Erik Rijkers (#1)
Re: pg_restore --clean text

Erik Rijkers wrote:

The help text for the pg_restore --clean option in the documentation is IMHO more precise than the
text that the pg_restore binary gives:

documentation:
-c
--clean
Clean (drop) database objects before recreating them.

pg_restore binary:
-c, --clean clean (drop) schema prior to create

So I think it would be an improvement to channge the pg_restore --help text:

I used the wording from the pg_restore SGML manual page in the --help
text, to be more consistent. Thanks for the report.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Attachments:

/rtmp/difftext/x-diffDownload+2-2
#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Bruce Momjian (#2)
Re: pg_restore --clean text

Bruce Momjian <bruce@momjian.us> writes:

I used the wording from the pg_restore SGML manual page in the --help
text, to be more consistent. Thanks for the report.

pg_dump has the same wording. pg_dumpall might need adjustment too,
though I'm not sure (note its --clean acts on DBs not individual
objects)

regards, tom lane

#4Bruce Momjian
bruce@momjian.us
In reply to: Tom Lane (#3)
Re: pg_restore --clean text

Tom Lane wrote:

Bruce Momjian <bruce@momjian.us> writes:

I used the wording from the pg_restore SGML manual page in the --help
text, to be more consistent. Thanks for the report.

pg_dump has the same wording. pg_dumpall might need adjustment too,
though I'm not sure (note its --clean acts on DBs not individual
objects)

OK, done with attached patch.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Attachments:

/rtmp/difftext/x-diffDownload+4-4