VARSIZE - why omit VARLEN?

Started by Andrew Chernowalmost 17 years ago3 messages
#1Andrew Chernow
ac@esilo.com

Any objections adding the below to postgres.h?

#define VARLEN(PTR) (VARSIZE(PTR) - VARHDRSZ)

It adds a little more abstraction and cleans up userland code.

--
Andrew Chernow
eSilo, LLC
every bit counts
http://www.esilo.com/

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Andrew Chernow (#1)
Re: VARSIZE - why omit VARLEN?

Andrew Chernow <ac@esilo.com> writes:

Any objections adding the below to postgres.h?
#define VARLEN(PTR) (VARSIZE(PTR) - VARHDRSZ)

For the most part, you should probably be using VARSIZE_ANY_EXHDR
anyplace that that might be a good idea.

regards, tom lane

#3Andrew Chernow
ac@esilo.com
In reply to: Tom Lane (#2)
Re: VARSIZE - why omit VARLEN?

Tom Lane wrote:

Andrew Chernow <ac@esilo.com> writes:

Any objections adding the below to postgres.h?
#define VARLEN(PTR) (VARSIZE(PTR) - VARHDRSZ)

For the most part, you should probably be using VARSIZE_ANY_EXHDR
anyplace that that might be a good idea.

regards, tom lane

Thanks, that will do it. I didn't know that macro existed. I missed its
addition in 8.3. sorry.

--
Andrew Chernow
eSilo, LLC
every bit counts
http://www.esilo.com/