New pg_dump patch -- document statistics collector exception

Started by Bryce Nesbittabout 17 years ago13 messageshackers
Jump to latest
#1Bryce Nesbitt
bryce2@obviously.com

This is a proposed patch to document disabling the statistics collector
pg_dump activity, and give a bit more visibility to the PGOPTIONS
environment variable supported by libpq.

It is an alternative to the prior patch, which supplied a --no-stats flag.

This is a documentation only patch, not tied to a recent code change.

Attachments:

pgdump_man.patchtext/x-diff; name=pgdump_man.patchDownload+12-1
#2Robert Treat
xzilla@users.sourceforge.net
In reply to: Bryce Nesbitt (#1)
Re: New pg_dump patch -- document statistics collector exception

On Tuesday 20 January 2009 20:22:10 Bryce Nesbitt wrote:

This is a proposed patch to document disabling the statistics collector
pg_dump activity, and give a bit more visibility to the PGOPTIONS
environment variable supported by libpq.

It is an alternative to the prior patch, which supplied a --no-stats flag.

This is a documentation only patch, not tied to a recent code change.

s/varriable/variable/g

also, I forget which way is proper, but you're inconsistent with your closing
tags for <application> in that paragraph (using both </application and </>)

--
Robert Treat
Conjecture: http://www.xzilla.net
Consulting: http://www.omniti.com

#3Alvaro Herrera
alvherre@2ndquadrant.com
In reply to: Robert Treat (#2)
Re: New pg_dump patch -- document statistics collector exception

Robert Treat wrote:

also, I forget which way is proper, but you're inconsistent with your closing
tags for <application> in that paragraph (using both </application and </>)

They're both acceptable.

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

#4Bryce Nesbitt
bryce2@obviously.com
In reply to: Alvaro Herrera (#3)
Re: New pg_dump patch -- document statistics collector exception (REVISED PATCH)

Here's a revision (thanks Robert Treat for the spelling corrextion).
If there are no other objections, how do I nominate it for consideration?
-Bryce

Attachments:

pgsl_doc_src_sgml.patchtext/x-diff; name=pgsl_doc_src_sgml.patchDownload+14-1
#5Josh Berkus
josh@agliodbs.com
In reply to: Bryce Nesbitt (#4)
Re: New pg_dump patch -- document statistics collector exception (REVISED PATCH)

Bryce Nesbitt wrote:

Here's a revision (thanks Robert Treat for the spelling corrextion).
If there are no other objections, how do I nominate it for consideration?
-Bryce

You already have.

Mind you, in the future when you're not continuing a discussion from a
code patch, you should submit doc patches to pgsql-docs. But I'm sure
Peter has seen it here.

--Josh

In reply to: Bryce Nesbitt (#4)
Re: New pg_dump patch -- document statistics collector exception (REVISED PATCH)

Bryce Nesbitt escreveu:

Here's a revision (thanks Robert Treat for the spelling corrextion).
If there are no other objections, how do I nominate it for consideration?

Added to next commit fest [1]http://wiki.postgresql.org/wiki/CommitFest_2009-First.

[1]: http://wiki.postgresql.org/wiki/CommitFest_2009-First

--
Euler Taveira de Oliveira
http://www.timbira.com/

#7Josh Berkus
josh@agliodbs.com
In reply to: Euler Taveira de Oliveira (#6)
Re: New pg_dump patch -- document statistics collector exception (REVISED PATCH)

Euler Taveira de Oliveira wrote:

Bryce Nesbitt escreveu:

Here's a revision (thanks Robert Treat for the spelling corrextion).
If there are no other objections, how do I nominate it for consideration?

Added to next commit fest [1].

Um, not necessary. We're still accepting new doc patches, and will
until the end of beta.

--Josh

#8Bruce Momjian
bruce@momjian.us
In reply to: Bryce Nesbitt (#1)
Re: New pg_dump patch -- document statistics collector exception

Bryce Nesbitt wrote:

This is a proposed patch to document disabling the statistics collector
pg_dump activity, and give a bit more visibility to the PGOPTIONS
environment variable supported by libpq.

It is an alternative to the prior patch, which supplied a --no-stats flag.

This is a documentation only patch, not tied to a recent code change.

Patch applied, with spelling correction already noted.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

#9Bruce Momjian
bruce@momjian.us
In reply to: Josh Berkus (#7)
Re: New pg_dump patch -- document statistics collector exception (REVISED PATCH)

Josh Berkus wrote:

Euler Taveira de Oliveira wrote:

Bryce Nesbitt escreveu:

Here's a revision (thanks Robert Treat for the spelling corrextion).
If there are no other objections, how do I nominate it for consideration?

Added to next commit fest [1].

Um, not necessary. We're still accepting new doc patches, and will
until the end of beta.

Yep, patch commited, removed from next commit fest.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

#10Bryce Nesbitt
bryce2@obviously.com
In reply to: Bruce Momjian (#8)
Re: New pg_dump patch -- document statistics collector exception

Attachments:

pg_dump.patchtext/x-diff; name=pg_dump.patchDownload+14-0
#11Bruce Momjian
bruce@momjian.us
In reply to: Bryce Nesbitt (#10)
Re: New pg_dump patch -- document statistics collector exception

Apologies. Turns out the name of the relevant setting was changed
for 8.3! So a revised patch is attached.
For backing, see:
http://www.postgresql.org/docs/8.3/static/release-8-3.html
" Numerous changes in administrative server parameters...
stats_block_level and stats_row_level are merged into track_counts."
Bryce Nesbitt wrote:

We don't want a pg_dump flag; the doc mention is good enough.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

#12Bryce Nesbitt
bryce2@obviously.com
In reply to: Bruce Momjian (#11)
Re: New pg_dump patch -- document statistics collector exception

Attachments:

pg_doc_patch.patchtext/x-diff; name=pg_doc_patch.patchDownload+12-12
#13Bruce Momjian
bruce@momjian.us
In reply to: Bryce Nesbitt (#12)
Re: New pg_dump patch -- document statistics collector exception

We don't want a pg_dump flag; the doc mention is good enough.

Doh! Try this one instead. Postgres 8.3 changed the name of the
flag mentioned in the doc.

[ Please avoid html-only email.]

OK, patch applied, but I removed the mention of pre-8.3 because this is
going only in the 8.4 docs.

Thanks.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +