Wrong comment in ReadControlFile
When we have now collation per database I think following comment is
useless:
* (2) this code is executed in the postmaster, so the setlocale() will
* propagate to forked backends, which aren't going to read this file for
* themselves. (These locale settings are considered critical
* compatibility items because they can affect sort order of indexes.)
Patch attached.
Zdenek
Attachments:
xlog_comment.patchtext/x-patch; charset=UTF-8; name=xlog_comment.patchDownload
*** pgsql.orig.1f40b253cd5f/src/backend/access/transam/xlog.c 2009-02-07 10:04:18.526406897 +0100
--- /export/home/zk200664/work/mercurial/pgsql.orig/src/backend/access/transam/xlog.c 2009-02-07 10:03:41.167554240 +0100
***************
*** 4045,4059 ****
(errmsg("incorrect checksum in control file")));
/*
! * Do compatibility checking immediately. We do this here for 2 reasons:
*
* (1) if the database isn't compatible with the backend executable, we
* want to abort before we can possibly do any damage;
*
- * (2) this code is executed in the postmaster, so the setlocale() will
- * propagate to forked backends, which aren't going to read this file for
- * themselves. (These locale settings are considered critical
- * compatibility items because they can affect sort order of indexes.)
*/
if (ControlFile->catalog_version_no != CATALOG_VERSION_NO)
ereport(FATAL,
--- 4045,4055 ----
(errmsg("incorrect checksum in control file")));
/*
! * Do compatibility checking immediately. We do this here for 1 reason:
*
* (1) if the database isn't compatible with the backend executable, we
* want to abort before we can possibly do any damage;
*
*/
if (ControlFile->catalog_version_no != CATALOG_VERSION_NO)
ereport(FATAL,
Zdenek Kotala wrote:
When we have now collation per database I think following comment is
useless:* (2) this code is executed in the postmaster, so the setlocale() will
* propagate to forked backends, which aren't going to read this file for
* themselves. (These locale settings are considered critical
* compatibility items because they can affect sort order of indexes.)Patch attached.
Heikki has applied your patch. Thanks.
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
Zdenek Kotala wrote:
When we have now collation per database I think following comment is
useless:* (2) this code is executed in the postmaster, so the setlocale() will
* propagate to forked backends, which aren't going to read this file for
* themselves. (These locale settings are considered critical
* compatibility items because they can affect sort order of indexes.)Patch attached.
Thanks, committed.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com