Wrong comment in ReadControlFile

Started by Zdenek Kotalaabout 17 years ago3 messageshackers
Jump to latest
#1Zdenek Kotala
Zdenek.Kotala@Sun.COM

When we have now collation per database I think following comment is
useless:

* (2) this code is executed in the postmaster, so the setlocale() will
* propagate to forked backends, which aren't going to read this file for
* themselves. (These locale settings are considered critical
* compatibility items because they can affect sort order of indexes.)

Patch attached.

Zdenek

Attachments:

xlog_comment.patchtext/x-patch; charset=UTF-8; name=xlog_comment.patchDownload+2-6
#2Bruce Momjian
bruce@momjian.us
In reply to: Zdenek Kotala (#1)
Re: Wrong comment in ReadControlFile

Zdenek Kotala wrote:

When we have now collation per database I think following comment is
useless:

* (2) this code is executed in the postmaster, so the setlocale() will
* propagate to forked backends, which aren't going to read this file for
* themselves. (These locale settings are considered critical
* compatibility items because they can affect sort order of indexes.)

Patch attached.

Heikki has applied your patch. Thanks.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

#3Heikki Linnakangas
heikki.linnakangas@enterprisedb.com
In reply to: Zdenek Kotala (#1)
Re: Wrong comment in ReadControlFile

Zdenek Kotala wrote:

When we have now collation per database I think following comment is
useless:

* (2) this code is executed in the postmaster, so the setlocale() will
* propagate to forked backends, which aren't going to read this file for
* themselves. (These locale settings are considered critical
* compatibility items because they can affect sort order of indexes.)

Patch attached.

Thanks, committed.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com