model-writtenrun 8135 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Peter Eisentraut announced exposing the internal int64-to-numeric conversion function to simplify callers previously using DirectFunctionCall1() in #1.
- David Rowley reported that this change introduced MSVC warning C4334 about a 32-bit shift being converted to a 64-bit result in src/backend/utils/adt/dbsize.c #2.
- David explained that existing callers always shift by constants below 32, so the warning did not indicate an overflow in current usage #2.
- David attached a one-line fix casting 1 to int64 before shifting and said he intended to push it unless anyone proposed an alternative #2.
- The attached fix landed unchanged as fe4f36bcde, completing the only patchset in this thread.