[PATCH] Regression test fix for Czech locale

Zdenek Kotala wrote:

I attached fix which modify foreign_data test. It fix problem with Czech
collation when numbers are ordered after letters. I retyped affected
column to name datatype which uses bitwise cmp.

I have trouble understanding why this makes any sense at all. The only
thing you seem to be doing here is replacing the ORDER BY column-number
clauses by others that reference the column by name.

Isn't this a bug in how column numbers are (not) being used by ORDER BY?

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

Alvaro Herrera píše v pá 06. 03. 2009 v 12:16 -0300:

Zdenek Kotala wrote:

I attached fix which modify foreign_data test. It fix problem with Czech
collation when numbers are ordered after letters. I retyped affected
column to name datatype which uses bitwise cmp.

I have trouble understanding why this makes any sense at all. The only
thing you seem to be doing here is replacing the ORDER BY column-number
clauses by others that reference the column by name.

And I cast foreign_server_name to name datatype (which is original
datatype in catalog table). See my buildfarm member:

http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=gothic_moth&dt=2009-03-04%2021:06:01

for details.

Isn't this a bug in how column numbers are (not) being used by ORDER BY?

you cannot use 3::name. It is reason why I replaced numbers with names
and I did it for all select here. It has seemed that is better idea do
it everywhere and be consistent.

Zdenek

Zdenek Kotala wrote:

I attached fix which modify foreign_data test. It fix problem with Czech
collation when numbers are ordered after letters. I retyped affected
column to name datatype which uses bitwise cmp.

I have chosen a different fix: rename the identifiers so the ordering
problem doesn't arise. Czech locale should work now.