Jan 2022

2 commits
More cleanup of a2ab9c06ea.
9 Jan 2022Jeff Davismaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1Also in: Non-superuser subscription owners (written from the discussion, no matching patch)
LLM analysis, 99% surewritten from the discussion, no matching patch

The initial-sync wait in src/test/subscription/t/027_nosuperuser.pl implements Amit's diagnosis in #3, confirmed by Jeff in #6, without a matching attachment. Consistent with the verdict for thread #44989, this commit combines that fix with SELECT privilege checks and test simplification discussed there; it does not originate exclusively in either thread.

Fix pgperlcritic complaint, per buildfarm.
8 Jan 2022Jeff Davismaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #42 of 2 reviewers saw the final version

The commit exactly matches the nine prototype removals in src/test/subscription/t/027_nosuperuser.pl attached in #4, and its author credit names the patchset sender, Michael Paquier.

  • Andrew Dunstansaw the final versionLLM analysis, 100% sureAndrew endorsed applying #4 and explained why Perl subroutine prototypes should be avoided in #5.
  • Jeff Davissaw the final versioncommittercommitted the patch

Credits across 2 commits

Author
Michael Paquier1
Reviewer
Jeff Daviscommitter1
Committer
Jeff Davis2