Extraneous newlines in logfile from vacuumdb

Started by Tim Landscheidtover 16 years ago2 messageshackers
Jump to latest
#1Tim Landscheidt
tim@tim-landscheidt.de

Hi,

log file entries from running vacuumdb are "double-spaced",
as vacuumdb ends the commands with ";\n" (cf. attached mini-
patch). Is there a deeper meaning in that, or could it be
trimmed?

TIA,
Tim

Attachments:

vacuumdb.patchtext/x-patchDownload+1-1
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Tim Landscheidt (#1)
Re: Extraneous newlines in logfile from vacuumdb

Tim Landscheidt <tim@tim-landscheidt.de> writes:

log file entries from running vacuumdb are "double-spaced",
as vacuumdb ends the commands with ";\n" (cf. attached mini-
patch). Is there a deeper meaning in that, or could it be
trimmed?

There are a LOT of clients that tend to send queries with trailing
newlines; I'm pretty sure that both pg_dump and psql have instances of
that, for example. If we were to do something about this, which I'm
entirely unconvinced we should, it'd be better to strip trailing
whitespace from the logged query inside the backend.

regards, tom lane