Patch to change a pg_restore message

Started by Guillaume Lelargeabout 16 years ago3 messages
#1Guillaume Lelarge
guillaume@lelarge.info
1 attachment(s)

Hi,

"pg_restore --help" gives this message for the --no-tablespaces parameter:

--no-tablespaces do not dump tablespace assignments

The message should say "restore" and not "dump". You'll find a patch attached
that fixes this issue.

Thanks.

Regards.

--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com

Attachments:

pg_restore.patchtext/x-patch; charset=UTF-8; name=pg_restore.patchDownload
Index: src/bin/pg_dump/pg_restore.c
===================================================================
RCS file: /opt/cvsroot_postgresql/pgsql/src/bin/pg_dump/pg_restore.c,v
retrieving revision 1.100
diff -c -p -c -r1.100 pg_restore.c
*** src/bin/pg_dump/pg_restore.c	11 Jun 2009 14:49:07 -0000	1.100
--- src/bin/pg_dump/pg_restore.c	19 Nov 2009 15:41:23 -0000
*************** usage(const char *progname)
*** 430,436 ****
  	printf(_("  --no-data-for-failed-tables\n"
  			 "                           do not restore data of tables that could not be\n"
  			 "                           created\n"));
! 	printf(_("  --no-tablespaces         do not dump tablespace assignments\n"));
  	printf(_("  --role=ROLENAME          do SET ROLE before restore\n"));
  	printf(_("  --use-set-session-authorization\n"
  			 "                           use SET SESSION AUTHORIZATION commands instead of\n"
--- 430,436 ----
  	printf(_("  --no-data-for-failed-tables\n"
  			 "                           do not restore data of tables that could not be\n"
  			 "                           created\n"));
! 	printf(_("  --no-tablespaces         do not restore tablespace assignments\n"));
  	printf(_("  --role=ROLENAME          do SET ROLE before restore\n"));
  	printf(_("  --use-set-session-authorization\n"
  			 "                           use SET SESSION AUTHORIZATION commands instead of\n"
#2Peter Eisentraut
peter_e@gmx.net
In reply to: Guillaume Lelarge (#1)
Re: Patch to change a pg_restore message

On tor, 2009-11-19 at 16:47 +0100, Guillaume Lelarge wrote:

"pg_restore --help" gives this message for the --no-tablespaces parameter:

--no-tablespaces do not dump tablespace assignments

The message should say "restore" and not "dump". You'll find a patch attached
that fixes this issue.

Fixed in 8.4 and 8.5.

#3Guillaume Lelarge
guillaume@lelarge.info
In reply to: Peter Eisentraut (#2)
Re: Patch to change a pg_restore message

Le jeudi 19 novembre 2009 à 23:05:16, Peter Eisentraut a écrit :

On tor, 2009-11-19 at 16:47 +0100, Guillaume Lelarge wrote:

"pg_restore --help" gives this message for the --no-tablespaces
parameter:

--no-tablespaces do not dump tablespace assignments

The message should say "restore" and not "dump". You'll find a patch
attached that fixes this issue.

Fixed in 8.4 and 8.5.

Thanks Peter.

--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com