ecpg.addons

Started by Michael Meskesabout 16 years ago3 messages
#1Michael Meskes
meskes@postgresql.org

I wrote a hackish little script that checks if all rules in ecpg.addons are
indeed used to create the precompiler's parser to catch renamed symbol and
similar changes. Now I wonder whether this should be added to the build
process. If it is, the buildfarm will catch every such change, not just the
ones breaking the regression tests. However, this might also make the buildfarm
become red if only a very minor and unimportant change is not syncronized.

Any comment?

Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
ICQ: 179140304, AIM/Yahoo/Skype: michaelmeskes, Jabber: meskes@jabber.org
VfL Borussia! Forca Barca! Go SF 49ers! Use: Debian GNU/Linux, PostgreSQL

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Michael Meskes (#1)
Re: ecpg.addons

Michael Meskes <meskes@postgresql.org> writes:

I wrote a hackish little script that checks if all rules in ecpg.addons are
indeed used to create the precompiler's parser to catch renamed symbol and
similar changes. Now I wonder whether this should be added to the build
process. If it is, the buildfarm will catch every such change, not just the
ones breaking the regression tests. However, this might also make the buildfarm
become red if only a very minor and unimportant change is not syncronized.

Any comment?

The point of the buildfarm is to catch mistakes ...

regards, tom lane

#3Michael Meskes
meskes@postgresql.org
In reply to: Tom Lane (#2)
Re: ecpg.addons

On Thu, Nov 26, 2009 at 11:14:54AM -0500, Tom Lane wrote:

Michael Meskes <meskes@postgresql.org> writes:

I wrote a hackish little script that checks if all rules in ecpg.addons are
indeed used to create the precompiler's parser to catch renamed symbol and
similar changes. Now I wonder whether this should be added to the build
process. If it is, the buildfarm will catch every such change, not just the
ones breaking the regression tests. However, this might also make the buildfarm
become red if only a very minor and unimportant change is not syncronized.

Any comment?

The point of the buildfarm is to catch mistakes ...

Okay, committed. As you guys know I don't really speak perl, so feel free to go
in and fix whatever stupid perl mistake I made.

Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
ICQ: 179140304, AIM/Yahoo/Skype: michaelmeskes, Jabber: meskes@jabber.org
VfL Borussia! Forca Barca! Go SF 49ers! Use: Debian GNU/Linux, PostgreSQL