pgsql: Don't unblock SIGQUIT in the SIGQUIT handler This was possibly

Started by Nonameabout 16 years ago3 messages
#1Noname
petere@postgresql.org

Log Message:
-----------
Don't unblock SIGQUIT in the SIGQUIT handler

This was possibly linked to a deadlock-like situation in glibc syslog code
invoked by the ereport call in quickdie(). In any case, a signal handler
should not unblock its own signal unless there is a specific reason to.

Modified Files:
--------------
pgsql/src/backend/tcop:
postgres.c (r1.577 -> r1.578)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/tcop/postgres.c?r1=1.577&r2=1.578)
pgsql/src/include/libpq:
pqsignal.h (r1.35 -> r1.36)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/libpq/pqsignal.h?r1=1.35&r2=1.36)

#2Fujii Masao
masao.fujii@gmail.com
In reply to: Noname (#1)
Re: [COMMITTERS] pgsql: Don't unblock SIGQUIT in the SIGQUIT handler This was possibly

On Thu, Dec 17, 2009 at 8:05 AM, Peter Eisentraut <petere@postgresql.org> wrote:

Log Message:
-----------
Don't unblock SIGQUIT in the SIGQUIT handler

This was possibly linked to a deadlock-like situation in glibc syslog code
invoked by the ereport call in quickdie().  In any case, a signal handler
should not unblock its own signal unless there is a specific reason to.

Modified Files:
--------------
   pgsql/src/backend/tcop:
       postgres.c (r1.577 -> r1.578)
       (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/tcop/postgres.c?r1=1.577&amp;r2=1.578)
   pgsql/src/include/libpq:
       pqsignal.h (r1.35 -> r1.36)
       (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/libpq/pqsignal.h?r1=1.35&amp;r2=1.36)

Why wasn't this patch backported? Recently my customer encountered
the bug which this patch fixed, in 8.3.

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

#3Peter Eisentraut
petere@postgresql.org
In reply to: Fujii Masao (#2)
Re: Re: [COMMITTERS] pgsql: Don't unblock SIGQUIT in the SIGQUIT handler This was possibly

On ons, 2010-11-10 at 20:30 +0900, Fujii Masao wrote:

On Thu, Dec 17, 2009 at 8:05 AM, Peter Eisentraut <petere@postgresql.org> wrote:

Log Message:
-----------
Don't unblock SIGQUIT in the SIGQUIT handler

This was possibly linked to a deadlock-like situation in glibc syslog code
invoked by the ereport call in quickdie(). In any case, a signal handler
should not unblock its own signal unless there is a specific reason to.

Modified Files:
--------------
pgsql/src/backend/tcop:
postgres.c (r1.577 -> r1.578)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/tcop/postgres.c?r1=1.577&amp;r2=1.578)
pgsql/src/include/libpq:
pqsignal.h (r1.35 -> r1.36)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/libpq/pqsignal.h?r1=1.35&amp;r2=1.36)

Why wasn't this patch backported? Recently my customer encountered
the bug which this patch fixed, in 8.3.

It was at the time a perhaps experimental behavioral change.

I'm also running a 8.3 version with this patched in, though.