ecpg compile error

Bruce Momjian wrote:

I am seeing a compile failure in current CVS because my operating
system, BSD/OS, does not have inttypes.h:

ccache gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith
-fno-strict-aliasing -O1 -Wall -Wmissing-prototypes
-Wmissing-declarations -Wpointer-arith -Wcast-align -pthread
-D_REENTRANT -D_THREAD_SAFE -D_POSIX_PTHREAD_SEMANTICS -fpic
-I../include -I../../../../src/interfaces/ecpg/include
-I../../../../src/interfaces/libpq -I../../../../src/port
-I../../../../src/include -I/usr/local/include/readline
-I/usr/contrib/include -DSO_MAJOR_VERSION=6 -c -o sqlda.o sqlda.c
sqlda.c:13: inttypes.h: No such file or directory

I think I see a few other platforms that have a problem:

http://www.pgbuildfarm.org/cgi-bin/show_status.pl

(I introduced a compile bug 30 minutes ago (OIDCHARS) but I fixed that.)

Surprisingly, I am able to compile and pass all regression tests without
that include.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Bruce Momjian �rta:

Bruce Momjian wrote:

I am seeing a compile failure in current CVS because my operating
system, BSD/OS, does not have inttypes.h:

ccache gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith
-fno-strict-aliasing -O1 -Wall -Wmissing-prototypes
-Wmissing-declarations -Wpointer-arith -Wcast-align -pthread
-D_REENTRANT -D_THREAD_SAFE -D_POSIX_PTHREAD_SEMANTICS -fpic
-I../include -I../../../../src/interfaces/ecpg/include
-I../../../../src/interfaces/libpq -I../../../../src/port
-I../../../../src/include -I/usr/local/include/readline
-I/usr/contrib/include -DSO_MAJOR_VERSION=6 -c -o sqlda.o sqlda.c
sqlda.c:13: inttypes.h: No such file or directory

I think I see a few other platforms that have a problem:

http://www.pgbuildfarm.org/cgi-bin/show_status.pl

(I introduced a compile bug 30 minutes ago (OIDCHARS) but I fixed that.)

Surprisingly, I am able to compile and pass all regression tests without
that include.

How can it be that the regression tests work for you
if you deleted the inttypes.h only from sqlda.c?
ecpg/test/{sql,compat_informix}/sqlda.pgc also contain
that header to use PRId64 to print int64 in a portable way.

BTW, the #include in sqlda.c was a leftover from debugging.

Best regards,
Zolt�n B�sz�rm�nyi

--
Bible has answers for everything. Proof:
"But let your communication be, Yea, yea; Nay, nay: for whatsoever is more
than these cometh of evil." (Matthew 5:37) - basics of digital technology.
"May your kingdom come" - superficial description of plate tectonics

----------------------------------
Zolt�n B�sz�rm�nyi
Cybertec Sch�nig & Sch�nig GmbH
http://www.postgresql.at/

Boszormenyi Zoltan �rta:

Bruce Momjian �rta:

Bruce Momjian wrote:

I am seeing a compile failure in current CVS because my operating
system, BSD/OS, does not have inttypes.h:

ccache gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith
-fno-strict-aliasing -O1 -Wall -Wmissing-prototypes
-Wmissing-declarations -Wpointer-arith -Wcast-align -pthread
-D_REENTRANT -D_THREAD_SAFE -D_POSIX_PTHREAD_SEMANTICS -fpic
-I../include -I../../../../src/interfaces/ecpg/include
-I../../../../src/interfaces/libpq -I../../../../src/port
-I../../../../src/include -I/usr/local/include/readline
-I/usr/contrib/include -DSO_MAJOR_VERSION=6 -c -o sqlda.o sqlda.c
sqlda.c:13: inttypes.h: No such file or directory

I think I see a few other platforms that have a problem:

http://www.pgbuildfarm.org/cgi-bin/show_status.pl

The systems that have the "ECPG-Check error" are
32-bit systems, it seems it was a bad idea to report
data offsets in ecpg_log()... I will send a patch.

(I introduced a compile bug 30 minutes ago (OIDCHARS) but I fixed that.)

Surprisingly, I am able to compile and pass all regression tests without
that include.

How can it be that the regression tests work for you
if you deleted the inttypes.h only from sqlda.c?
ecpg/test/{sql,compat_informix}/sqlda.pgc also contain
that header to use PRId64 to print int64 in a portable way.

BTW, the #include in sqlda.c was a leftover from debugging.

Best regards,
Zolt�n B�sz�rm�nyi

--
Bible has answers for everything. Proof:
"But let your communication be, Yea, yea; Nay, nay: for whatsoever is more
than these cometh of evil." (Matthew 5:37) - basics of digital technology.
"May your kingdom come" - superficial description of plate tectonics

----------------------------------
Zolt�n B�sz�rm�nyi
Cybertec Sch�nig & Sch�nig GmbH
http://www.postgresql.at/

Hi,

Boszormenyi Zoltan �rta:

Boszormenyi Zoltan �rta:

Bruce Momjian �rta:

Bruce Momjian wrote:

I think I see a few other platforms that have a problem:

http://www.pgbuildfarm.org/cgi-bin/show_status.pl

The systems that have the "ECPG-Check error" are
32-bit systems, it seems it was a bad idea to report
data offsets in ecpg_log()... I will send a patch.

Attached. Passes "make check" here on 32-bit and
64-bit builds under Fedora 9/x86-64.

(I introduced a compile bug 30 minutes ago (OIDCHARS) but I fixed that.)

Surprisingly, I am able to compile and pass all regression tests without
that include.

How can it be that the regression tests work for you
if you deleted the inttypes.h only from sqlda.c?
ecpg/test/{sql,compat_informix}/sqlda.pgc also contain
that header to use PRId64 to print int64 in a portable way.

BTW, the #include in sqlda.c was a leftover from debugging.

Best regards,
Zolt�n B�sz�rm�nyi

--
Bible has answers for everything. Proof:
"But let your communication be, Yea, yea; Nay, nay: for whatsoever is more
than these cometh of evil." (Matthew 5:37) - basics of digital technology.
"May your kingdom come" - superficial description of plate tectonics

----------------------------------
Zolt�n B�sz�rm�nyi
Cybertec Sch�nig & Sch�nig GmbH
http://www.postgresql.at/

On Tue, Jan 05, 2010 at 09:49:27PM -0500, Bruce Momjian wrote:

I am seeing a compile failure in current CVS because my operating
system, BSD/OS, does not have inttypes.h:

Sorry, missed this. I did remove it in another file, but didn't notice it's
here too. Should be fixed now that I committed Zoltan's patch.

Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
ICQ: 179140304, AIM/Yahoo/Skype: michaelmeskes, Jabber: meskes@jabber.org
VfL Borussia! Forca Barca! Go SF 49ers! Use: Debian GNU/Linux, PostgreSQL

On Wed, Jan 06, 2010 at 09:42:06AM +0100, Boszormenyi Zoltan wrote:

Attached. Passes "make check" here on 32-bit and
64-bit builds under Fedora 9/x86-64.

Applied.

Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
ICQ: 179140304, AIM/Yahoo/Skype: michaelmeskes, Jabber: meskes@jabber.org
VfL Borussia! Forca Barca! Go SF 49ers! Use: Debian GNU/Linux, PostgreSQL