Apr 2024

2 commits
Minor improvements for waitlsn.c
3 Apr 2024Alexander Korotkovmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1Also in: Re: [HACKERS] make async slave to wait for lsn to be replayed (written from the discussion, no matching patch)
Move WaitLSNShmemInit() to CreateOrAttachShmemStructs()
2 Apr 2024Alexander Korotkovmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surewritten from the discussion, no matching patch3 of 3 reviewers saw the final version

Following 06c418e163, Thomas Munro proposed moving WaitLSNShmemInit() into CreateOrAttachShmemStructs() #3, and David Rowley explained the EXEC_BACKEND initialization failure #4. The commit implements exactly that move in src/backend/storage/ipc/ipci.c.

  • Thomas Munrosaw the final versionLLM analysis, 100% sureIdentified the EXEC_BACKEND null-pointer failure and proposed the initialization move adopted by the commit #3.
  • David Rowleysaw the final versionLLM analysis, 100% sureTraced the crash to waitLSN remaining uninitialized because EXEC_BACKEND children bypass CreateSharedMemoryAndSemaphores() #4.
  • Andres Freundsaw the final versionLLM analysis, 94% sureThe commit explicitly thanks him for investigating the issue, although no message from him appears in this thread 2c91e13013.

Credits across 2 commits

Reported by
Alvaro Herrera1
Daniel Gustafsson1
Masahiko Sawada1
Committer
Alexander Korotkov2