default pg_hba.conf tabulation

Started by Peter Eisentrautalmost 16 years ago5 messages
#1Peter Eisentraut
peter_e@gmx.net

When editing pg_hba.conf, I often instinctively try to use tabs, only to
be slightly annoyed because that barely doesn't work out relative to the
default entries, because those are aligned at column 0, 8, 20, 32, 54:

# TYPE DATABASE USER CIDR-ADDRESS METHOD
host all all 127.0.0.1/32 trust

Would it be OK to alter that to something like 0, 8, 24, 40, 56:

# TYPE DATABASE USER CIDR-ADDRESS METHOD
host all all 127.0.0.1/32 trust

?

#2Magnus Hagander
magnus@hagander.net
In reply to: Peter Eisentraut (#1)
Re: default pg_hba.conf tabulation

2010/1/25 Peter Eisentraut <peter_e@gmx.net>:

When editing pg_hba.conf, I often instinctively try to use tabs, only to
be slightly annoyed because that barely doesn't work out relative to the
default entries, because those are aligned at column 0, 8, 20, 32, 54:

# TYPE  DATABASE    USER        CIDR-ADDRESS          METHOD
host    all         all         127.0.0.1/32          trust

Would it be OK to alter that to something like 0, 8, 24, 40, 56:

# TYPE  DATABASE        USER            CIDR-ADDRESS    METHOD
host    all             all             127.0.0.1/32    trust

Sounds good to me.

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

#3Josh Berkus
josh@agliodbs.com
In reply to: Magnus Hagander (#2)
Re: default pg_hba.conf tabulation

On 1/25/10 1:24 PM, Magnus Hagander wrote:

2010/1/25 Peter Eisentraut <peter_e@gmx.net>:

When editing pg_hba.conf, I often instinctively try to use tabs, only to
be slightly annoyed because that barely doesn't work out relative to the
default entries, because those are aligned at column 0, 8, 20, 32, 54:

# TYPE DATABASE USER CIDR-ADDRESS METHOD
host all all 127.0.0.1/32 trust

Would it be OK to alter that to something like 0, 8, 24, 40, 56:

# TYPE DATABASE USER CIDR-ADDRESS METHOD
host all all 127.0.0.1/32 trust

Sounds good to me.

I can't see anyone objecting.

--Josh Berkus

#4Bruce Momjian
bruce@momjian.us
In reply to: Josh Berkus (#3)
Re: default pg_hba.conf tabulation

Josh Berkus wrote:

On 1/25/10 1:24 PM, Magnus Hagander wrote:

2010/1/25 Peter Eisentraut <peter_e@gmx.net>:

When editing pg_hba.conf, I often instinctively try to use tabs, only to
be slightly annoyed because that barely doesn't work out relative to the
default entries, because those are aligned at column 0, 8, 20, 32, 54:

# TYPE DATABASE USER CIDR-ADDRESS METHOD
host all all 127.0.0.1/32 trust

Would it be OK to alter that to something like 0, 8, 24, 40, 56:

# TYPE DATABASE USER CIDR-ADDRESS METHOD
host all all 127.0.0.1/32 trust

Sounds good to me.

I can't see anyone objecting.

Can we also change the "USER" column heading to "ROLE"?

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

#5David Fetter
david@fetter.org
In reply to: Bruce Momjian (#4)
Re: default pg_hba.conf tabulation

On Mon, Jan 25, 2010 at 05:29:54PM -0500, Bruce Momjian wrote:

Josh Berkus wrote:

On 1/25/10 1:24 PM, Magnus Hagander wrote:

2010/1/25 Peter Eisentraut <peter_e@gmx.net>:

When editing pg_hba.conf, I often instinctively try to use tabs, only to
be slightly annoyed because that barely doesn't work out relative to the
default entries, because those are aligned at column 0, 8, 20, 32, 54:

# TYPE DATABASE USER CIDR-ADDRESS METHOD
host all all 127.0.0.1/32 trust

Would it be OK to alter that to something like 0, 8, 24, 40, 56:

# TYPE DATABASE USER CIDR-ADDRESS METHOD
host all all 127.0.0.1/32 trust

Sounds good to me.

I can't see anyone objecting.

Can we also change the "USER" column heading to "ROLE"?

Does pg_hba.conf actually control any roles other than ones with
login? If not, USER is clearer, at least to me.

Cheers,
David.
--
David Fetter <david@fetter.org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david.fetter@gmail.com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate