recovery.conf.sample

Started by Fujii Masaoalmost 16 years ago4 messages

masao.fujii@gmail.com

almost 16 years ago

Hi,

recovery.conf.sample has the following section for Hot Standby.
Is this still required?

#---------------------------------------------------------------------------
# HOT STANDBY PARAMETERS
#---------------------------------------------------------------------------
#
# If you want to enable read-only connections during recovery, enable
# recovery_connections in postgresql.conf
#
#---------------------------------------------------------------------------

Heikki classified the recovery options into the following three
groups, in the document.

26.1. Archive recovery settings
26.2. Recovery target settings
26.3. Standby server settings

OTOH, recovery.conf.sample has classified them into the following
two groups. This is inconsistent with the document, and looks
confusing. How about modifying recovery.conf.sample to make the
grouping the same?

ARCHIVE RECOVERY PARAMETERS
LOG-STREAMING REPLICATION PARAMETERS

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Fujii Masao

masao.fujii@gmail.com

almost 16 years ago

In reply to: Fujii Masao (#1)

1 attachment(s)

Re: recovery.conf.sample

On Tue, Feb 23, 2010 at 1:44 PM, Fujii Masao <masao.fujii@gmail.com> wrote:

recovery.conf.sample has the following section for Hot Standby.
Is this still required?

#---------------------------------------------------------------------------
# HOT STANDBY PARAMETERS
#---------------------------------------------------------------------------
#
# If you want to enable read-only connections during recovery, enable
# recovery_connections in postgresql.conf
#
#---------------------------------------------------------------------------

Heikki classified the recovery options into the following three
groups, in the document.

26.1. Archive recovery settings
26.2. Recovery target settings
26.3. Standby server settings

OTOH, recovery.conf.sample has classified them into the following
two groups. This is inconsistent with the document, and looks
confusing. How about modifying recovery.conf.sample to make the
grouping the same?

ARCHIVE RECOVERY PARAMETERS
LOG-STREAMING REPLICATION PARAMETERS

The attached patch removes the unnecessary section about HS from
recovery.conf.sample. Also it changes the grouping of parameters
in recovery.conf.sample as mentioned above.

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Attachments:

change_recovery_conf_sample_v1.patchtext/x-patch; charset=US-ASCII; name=change_recovery_conf_sample_v1.patchDownload

*** a/src/backend/access/transam/recovery.conf.sample
--- b/src/backend/access/transam/recovery.conf.sample
***************
*** 55,60 ****
--- 55,64 ----
  #recovery_end_command = ''
  #
  #
+ #---------------------------------------------------------------------------
+ # RECOVERY TARGET PARAMETERS
+ #---------------------------------------------------------------------------
+ #
  # By default, recovery will rollforward to the end of the WAL log.
  # If you want to stop rollforward before that point, you
  # must set a recovery target.
***************
*** 79,85 ****
  #
  #
  #---------------------------------------------------------------------------
! # LOG-STREAMING REPLICATION PARAMETERS
  #---------------------------------------------------------------------------
  #
  # When standby_mode is enabled, the PostgreSQL server will work as
--- 83,89 ----
  #
  #
  #---------------------------------------------------------------------------
! # STANDBY SERVER PARAMETERS
  #---------------------------------------------------------------------------
  #
  # When standby_mode is enabled, the PostgreSQL server will work as
***************
*** 99,110 ****
  # when it's found.
  #
  #trigger_file = ''
- #
- #---------------------------------------------------------------------------
- # HOT STANDBY PARAMETERS
- #---------------------------------------------------------------------------
- #
- # If you want to enable read-only connections during recovery, enable
- # recovery_connections in postgresql.conf
- #
- #---------------------------------------------------------------------------
--- 103,105 ----

Simon Riggs

simon@2ndQuadrant.com

almost 16 years ago

In reply to: Fujii Masao (#2)

Re: recovery.conf.sample

On Wed, 2010-03-03 at 21:51 +0900, Fujii Masao wrote:

The attached patch removes the unnecessary section about HS from
recovery.conf.sample. Also it changes the grouping of parameters
in recovery.conf.sample as mentioned above.

I think that comment block is useful for people to remind them that some
relevant parameters need to be set in postgresql.conf. They might
otherwise try to put them in recovery.conf and be surprised by the
result.

--
Simon Riggs www.2ndQuadrant.com

Heikki Linnakangas

heikki.linnakangas@enterprisedb.com

almost 16 years ago

In reply to: Fujii Masao (#2)

Re: recovery.conf.sample

Fujii Masao wrote:

On Tue, Feb 23, 2010 at 1:44 PM, Fujii Masao <masao.fujii@gmail.com> wrote:

recovery.conf.sample has the following section for Hot Standby.
Is this still required?

#---------------------------------------------------------------------------
# HOT STANDBY PARAMETERS
#---------------------------------------------------------------------------
#
# If you want to enable read-only connections during recovery, enable
# recovery_connections in postgresql.conf
#
#---------------------------------------------------------------------------

Heikki classified the recovery options into the following three
groups, in the document.

26.1. Archive recovery settings
26.2. Recovery target settings
26.3. Standby server settings

OTOH, recovery.conf.sample has classified them into the following
two groups. This is inconsistent with the document, and looks
confusing. How about modifying recovery.conf.sample to make the
grouping the same?

ARCHIVE RECOVERY PARAMETERS
LOG-STREAMING REPLICATION PARAMETERS

The attached patch removes the unnecessary section about HS from
recovery.conf.sample. Also it changes the grouping of parameters
in recovery.conf.sample as mentioned above.

I committed the "LOG-STREAMING REPLICATION PARAMETERS" -> "STANDBY
SERVER PARAMETERS" rename. Simon added the "RECOVERY TARGET PARAMETERS"
heading already, and he wants to keep the Hot Standby section.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com