Mismatch in libpqwalreceiver

Started by Hitoshi Haradaalmost 16 years ago3 messages

Hitoshi Harada

umi.tanuki@gmail.com

almost 16 years ago

There's a mismatch in HEAD between README and the actual definition in
replication/libpqwalreceiver.

In README,

bool walrcv_receive(int timeout, XLogRecPtr *recptr, char **buffer, int *len)

but in walreceiver.h,

typedef bool (*walrcv_receive_type) (int timeout, unsigned char *type,
char **buffer, int *len);

It seems this commit forgot README fix.

http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/replication/walreceiver.h?r1=1.5&r2=1.6

Regards,

--
Hitoshi Harada

Fujii Masao

masao.fujii@gmail.com

almost 16 years ago

In reply to: Hitoshi Harada (#1)

1 attachment(s)

Re: Mismatch in libpqwalreceiver

On Wed, Mar 24, 2010 at 1:49 AM, Hitoshi Harada <umi.tanuki@gmail.com> wrote:

There's a mismatch in HEAD between README and the actual definition in
replication/libpqwalreceiver.

In README,

bool walrcv_receive(int timeout, XLogRecPtr *recptr, char **buffer, int *len)

but in walreceiver.h,

typedef bool (*walrcv_receive_type) (int timeout, unsigned char *type,
char **buffer, int *len);

It seems this commit forgot README fix.

http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/replication/walreceiver.h?r1=1.5&r2=1.6

Thanks for the report! That is my mistake. Here is the patch.

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Attachments:

walreceiver_readme_v1.patchapplication/octet-stream; name=walreceiver_readme_v1.patchDownload

*** a/src/backend/replication/README
--- b/src/backend/replication/README
***************
*** 17,25 **** Establish connection to the primary, and starts streaming from 'startpoint'.
  Returns true on success.
  
  
! bool walrcv_receive(int timeout, XLogRecPtr *recptr, char **buffer, int *len)
  
! Retrieve any WAL record available through the connection, blocking for
  maximum of 'timeout' ms.
  
  
--- 17,25 ----
  Returns true on success.
  
  
! bool walrcv_receive(int timeout, unsigned char *type, char **buffer, int *len)
  
! Retrieve any message available through the connection, blocking for
  maximum of 'timeout' ms.

Heikki Linnakangas

heikki.linnakangas@enterprisedb.com

almost 16 years ago

In reply to: Fujii Masao (#2)

Re: Mismatch in libpqwalreceiver

Fujii Masao wrote:

On Wed, Mar 24, 2010 at 1:49 AM, Hitoshi Harada <umi.tanuki@gmail.com> wrote:

It seems this commit forgot README fix.

http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/replication/walreceiver.h?r1=1.5&r2=1.6

Thanks for the report!

Yep, thanks. Applied, and I also added description of the returned values.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com