booleans in recovery.conf

On Wed, Mar 24, 2010 at 8:43 AM, Bruce Momjian <bruce@momjian.us> wrote:

Is there a reason that recovery.conf uses true/false, while
postgresql.conf uses on/off?

IIRC, because, in the old version, recovery.conf allowed only
true/false as a boolean value. Of course, we can change those
now.

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

On Tue, 2010-03-23 at 19:43 -0400, Bruce Momjian wrote:

Is there a reason that recovery.conf uses true/false, while
postgresql.conf uses on/off?

#recovery_target_inclusive = 'true' # 'true' or 'false'

or are these settings more boolean for some reason?

The code accepts any of on|off|true|false and uses the same code as the
postgresql.conf for parsing that.

I've changed the standby_mode to on|off as per the docs. I left the
above parameter because true|false reads better.

--
Simon Riggs www.2ndQuadrant.com

Simon Riggs wrote:

On Tue, 2010-03-23 at 19:43 -0400, Bruce Momjian wrote:

Is there a reason that recovery.conf uses true/false, while
postgresql.conf uses on/off?

#recovery_target_inclusive = 'true' # 'true' or 'false'

or are these settings more boolean for some reason?

The code accepts any of on|off|true|false and uses the same code as the
postgresql.conf for parsing that.

I've changed the standby_mode to on|off as per the docs. I left the
above parameter because true|false reads better.

Agreed. I also applied the attached change so defaults are listed and
example values only appear as comments in the file. This makes the file
match postgresql.conf in style.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com