pgsql: Add contraint exclusion section to contraint docs.

Started by Bruce Momjianabout 16 years ago12 messageshackers
Jump to latest
#1Bruce Momjian
bruce@momjian.us

Log Message:
-----------
Add contraint exclusion section to contraint docs.

Takahiro Itagaki

Modified Files:
--------------
pgsql/doc/src/sgml:
ddl.sgml (r1.90 -> r1.91)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/ddl.sgml?r1=1.90&r2=1.91)

#2Magnus Hagander
magnus@hagander.net
In reply to: Bruce Momjian (#1)
Re: pgsql: Add contraint exclusion section to contraint docs.

2010/4/1 Bruce Momjian <momjian@postgresql.org>:

Log Message:
-----------
Add contraint exclusion section to contraint docs.

Takahiro Itagaki

Modified Files:
--------------
   pgsql/doc/src/sgml:
       ddl.sgml (r1.90 -> r1.91)
       (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/ddl.sgml?r1=1.90&amp;r2=1.91)

Obviously, you mean exclusion constraint and not constraint exclusion
- yet another case of the bad choice of name showing up :P

(contents of the patch seem to get it right, though)

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

#3Bruce Momjian
bruce@momjian.us
In reply to: Magnus Hagander (#2)
Re: pgsql: Add contraint exclusion section to contraint docs.

Magnus Hagander wrote:

2010/4/1 Bruce Momjian <momjian@postgresql.org>:

Log Message:
-----------
Add contraint exclusion section to contraint docs.

Takahiro Itagaki

Modified Files:
--------------
? ?pgsql/doc/src/sgml:
? ? ? ?ddl.sgml (r1.90 -> r1.91)
? ? ? ?(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/ddl.sgml?r1=1.90&amp;r2=1.91)

Obviously, you mean exclusion constraint and not constraint exclusion
- yet another case of the bad choice of name showing up :P

(contents of the patch seem to get it right, though)

Yea.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

#4Simon Riggs
simon@2ndQuadrant.com
In reply to: Bruce Momjian (#3)
Re: pgsql: Add contraint exclusion section to contraint docs.

On Thu, 2010-04-01 at 09:51 -0400, Bruce Momjian wrote:

Magnus Hagander wrote:

2010/4/1 Bruce Momjian <momjian@postgresql.org>:

Log Message:
-----------
Add contraint exclusion section to contraint docs.

Takahiro Itagaki

Modified Files:
--------------
? ?pgsql/doc/src/sgml:
? ? ? ?ddl.sgml (r1.90 -> r1.91)
? ? ? ?(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/ddl.sgml?r1=1.90&amp;r2=1.91)

Obviously, you mean exclusion constraint and not constraint exclusion
- yet another case of the bad choice of name showing up :P

(contents of the patch seem to get it right, though)

Yea.

How about we call it "exclusivity constraints".

Not much of a change, but helps to differentiate.

--
Simon Riggs www.2ndQuadrant.com

#5Bruce Momjian
bruce@momjian.us
In reply to: Simon Riggs (#4)
Re: pgsql: Add contraint exclusion section to contraint docs.

Simon Riggs wrote:

On Thu, 2010-04-01 at 09:51 -0400, Bruce Momjian wrote:

Magnus Hagander wrote:

2010/4/1 Bruce Momjian <momjian@postgresql.org>:

Log Message:
-----------
Add contraint exclusion section to contraint docs.

Takahiro Itagaki

Modified Files:
--------------
? ?pgsql/doc/src/sgml:
? ? ? ?ddl.sgml (r1.90 -> r1.91)
? ? ? ?(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/ddl.sgml?r1=1.90&amp;r2=1.91)

Obviously, you mean exclusion constraint and not constraint exclusion
- yet another case of the bad choice of name showing up :P

(contents of the patch seem to get it right, though)

Yea.

How about we call it "exclusivity constraints".

Not much of a change, but helps to differentiate.

Well, the keyword is EXCLUDE so we could call it "EXCLUDE contraints".

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

#6Simon Riggs
simon@2ndQuadrant.com
In reply to: Bruce Momjian (#5)
Re: pgsql: Add contraint exclusion section to contraint docs.

On Sun, 2010-04-04 at 22:12 -0400, Bruce Momjian wrote:

Simon Riggs wrote:

How about we call it "exclusivity constraints".

Not much of a change, but helps to differentiate.

Well, the keyword is EXCLUDE so we could call it "EXCLUDE contraints".

If that is the keyword then that is what people will use, agreed.

That is poor English, but I think we can reword the sentences to allow
that phrase to make sense.

e.g. Added capability for EXCLUDE constraints.

--
Simon Riggs www.2ndQuadrant.com

#7Bruce Momjian
bruce@momjian.us
In reply to: Simon Riggs (#6)
Naming of new EXCLUDE constraints

Simon Riggs wrote:

On Sun, 2010-04-04 at 22:12 -0400, Bruce Momjian wrote:

Simon Riggs wrote:

How about we call it "exclusivity constraints".

Not much of a change, but helps to differentiate.

Well, the keyword is EXCLUDE so we could call it "EXCLUDE contraints".

If that is the keyword then that is what people will use, agreed.

That is poor English, but I think we can reword the sentences to allow
that phrase to make sense.

e.g. Added capability for EXCLUDE constraints.

I have modified the documentation with the attached patch to call this
new features "exclude constraints". Is this what everyone wants?

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

Attachments:

/pgpatches/excludetext/x-diffDownload+36-36
#8Robert Haas
robertmhaas@gmail.com
In reply to: Bruce Momjian (#7)
Re: Naming of new EXCLUDE constraints

On Mon, Apr 12, 2010 at 9:28 PM, Bruce Momjian <bruce@momjian.us> wrote:

Simon Riggs wrote:

On Sun, 2010-04-04 at 22:12 -0400, Bruce Momjian wrote:

Simon Riggs wrote:

How about we call it "exclusivity constraints".

Not much of a change, but helps to differentiate.

Well, the keyword is EXCLUDE so we could call it "EXCLUDE contraints".

If that is the keyword then that is what people will use, agreed.

That is poor English, but I think we can reword the sentences to allow
that phrase to make sense.

e.g. Added capability for EXCLUDE constraints.

I have modified the documentation with the attached patch to call this
new features "exclude constraints".  Is this what everyone wants?

I don't think we should be changing this without input from a lot more
people. We had a very, very long dicussion of this when this was
initially under development. Changing it now seems like a good way to
reopen a can of worms.

...Robert

#9Bruce Momjian
bruce@momjian.us
In reply to: Robert Haas (#8)
Re: Naming of new EXCLUDE constraints

Robert Haas wrote:

On Mon, Apr 12, 2010 at 9:28 PM, Bruce Momjian <bruce@momjian.us> wrote:

Simon Riggs wrote:

On Sun, 2010-04-04 at 22:12 -0400, Bruce Momjian wrote:

Simon Riggs wrote:

How about we call it "exclusivity constraints".

Not much of a change, but helps to differentiate.

Well, the keyword is EXCLUDE so we could call it "EXCLUDE contraints".

If that is the keyword then that is what people will use, agreed.

That is poor English, but I think we can reword the sentences to allow
that phrase to make sense.

e.g. Added capability for EXCLUDE constraints.

I have modified the documentation with the attached patch to call this
new features "exclude constraints". ?Is this what everyone wants?

I don't think we should be changing this without input from a lot more
people. We had a very, very long dicussion of this when this was
initially under development. Changing it now seems like a good way to
reopen a can of worms.

Fine, then we will just have to live with "exclusion constraints" and
"contraint exclusion".

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

#10Robert Haas
robertmhaas@gmail.com
In reply to: Bruce Momjian (#9)
Re: Naming of new EXCLUDE constraints

On Mon, Apr 12, 2010 at 11:03 PM, Bruce Momjian <bruce@momjian.us> wrote:

Robert Haas wrote:

On Mon, Apr 12, 2010 at 9:28 PM, Bruce Momjian <bruce@momjian.us> wrote:

Simon Riggs wrote:

On Sun, 2010-04-04 at 22:12 -0400, Bruce Momjian wrote:

Simon Riggs wrote:

How about we call it "exclusivity constraints".

Not much of a change, but helps to differentiate.

Well, the keyword is EXCLUDE so we could call it "EXCLUDE contraints".

If that is the keyword then that is what people will use, agreed.

That is poor English, but I think we can reword the sentences to allow
that phrase to make sense.

e.g. Added capability for EXCLUDE constraints.

I have modified the documentation with the attached patch to call this
new features "exclude constraints". ?Is this what everyone wants?

I don't think we should be changing this without input from a lot more
people.  We had a very, very long dicussion of this when this was
initially under development.  Changing it now seems like a good way to
reopen a can of worms.

Fine, then we will just have to live with "exclusion constraints" and
"contraint exclusion".

I am not necessarily 100% averse to changing it... just saying that it
shouldn't be done unless we have a clear consensus to overrule the
previous consensus.

...Robert

#11Tom Lane
tgl@sss.pgh.pa.us
In reply to: Robert Haas (#10)
Re: Naming of new EXCLUDE constraints

Robert Haas <robertmhaas@gmail.com> writes:

On Mon, Apr 12, 2010 at 11:03 PM, Bruce Momjian <bruce@momjian.us> wrote:

Fine, then we will just have to live with "exclusion constraints" and
"contraint exclusion".

I am not necessarily 100% averse to changing it... just saying that it
shouldn't be done unless we have a clear consensus to overrule the
previous consensus.

Well, I'm completely unimpressed with the proposed text, which includes
phrases like "uniqueness and exclude constraints". That leaves nothing
but the impression that these people don't speak the English too good.

regards, tom lane

#12Alvaro Herrera
alvherre@2ndquadrant.com
In reply to: Tom Lane (#11)
Re: Naming of new EXCLUDE constraints

Tom Lane escribi�:

Robert Haas <robertmhaas@gmail.com> writes:

On Mon, Apr 12, 2010 at 11:03 PM, Bruce Momjian <bruce@momjian.us> wrote:

Fine, then we will just have to live with "exclusion constraints" and
"contraint exclusion".

I am not necessarily 100% averse to changing it... just saying that it
shouldn't be done unless we have a clear consensus to overrule the
previous consensus.

Well, I'm completely unimpressed with the proposed text, which includes
phrases like "uniqueness and exclude constraints". That leaves nothing
but the impression that these people don't speak the English too good.

I think a simple fix would be to say "don't confuse exclusion contraints
with constraint exclusion" somewhere (presumably in documentation for
both features), just to raise awareness of the difference.

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.