Show schema name on REINDEX DATABASE
Patch attached to show the schema *and* table name when doing
a REINDEX DATABASE.
--
Greg Sabino Mullane greg@endpoint.com greg@turnstep.com
End Point Corporation
PGP Key: 0x14964AC8
Attachments:
reindex.database.show.schema.name.difftext/plain; charset=us-asciiDownload
Index: backend/commands/indexcmds.c
===================================================================
RCS file: /projects/cvsroot/pgsql/src/backend/commands/indexcmds.c,v
retrieving revision 1.195
diff -c -r1.195 indexcmds.c
*** backend/commands/indexcmds.c 22 Mar 2010 15:24:11 -0000 1.195
--- backend/commands/indexcmds.c 5 Apr 2010 16:21:02 -0000
***************
*** 1721,1727 ****
PushActiveSnapshot(GetTransactionSnapshot());
if (reindex_relation(relid, true, false))
ereport(NOTICE,
! (errmsg("table \"%s\" was reindexed",
get_rel_name(relid))));
PopActiveSnapshot();
CommitTransactionCommand();
--- 1721,1728 ----
PushActiveSnapshot(GetTransactionSnapshot());
if (reindex_relation(relid, true, false))
ereport(NOTICE,
! (errmsg("table \"%s.%s\" was reindexed",
! get_namespace_name(get_rel_namespace(relid)),
get_rel_name(relid))));
PopActiveSnapshot();
CommitTransactionCommand();
On Mon, Apr 5, 2010 at 9:29 AM, Greg Sabino Mullane <greg@turnstep.com> wrote:
Patch attached to show the schema *and* table name when doing
a REINDEX DATABASE.
Is this something that can be added to 9.1 commitfest?
-selena
--
http://chesnok.com/daily - me
Excerpts from Selena Deckelmann's message of mié may 26 11:07:40 -0400 2010:
On Mon, Apr 5, 2010 at 9:29 AM, Greg Sabino Mullane <greg@turnstep.com> wrote:
Patch attached to show the schema *and* table name when doing
a REINDEX DATABASE.Is this something that can be added to 9.1 commitfest?
Not in this form, apparently. Can we convince Greg or someone else to
work on adding some more error message fields?
--
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
-----BEGIN PGP SIGNED MESSAGE-----
Hash: RIPEMD160
Patch attached to show the schema *and* table name when doing
a REINDEX DATABASE.Is this something that can be added to 9.1 commitfest?
Not in this form, apparently. Can we convince Greg or someone else to
work on adding some more error message fields?
I think you might be confusing this with my somewhat more controversial
patch to show schemas when a COPY error occurs. This just changes
the normal output, not the error output. Nobody has complained
about this patch yet.
- --
Greg Sabino Mullane greg@turnstep.com
End Point Corporation http://www.endpoint.com/
PGP Key: 0x14964AC8 201005261728
http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8
-----BEGIN PGP SIGNATURE-----
iEYEAREDAAYFAkv9kvcACgkQvJuQZxSWSsgdvwCgygmLyKdAHKflL8WucdNvfuPn
84sAoOBuvAIgupEUcThNWW3KsPaIu9MQ
=Ptoe
-----END PGP SIGNATURE-----
Greg Sabino Mullane wrote:
-- Start of PGP signed section.
Patch attached to show the schema *and* table name when doing
a REINDEX DATABASE.
Yea, VACUUM VERBOSE shows the schema name, so REINDEX should as well.
Patch applied.
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ None of us is going to be here forever. +