Mar 2025

5 commits
Make amcanorder independent of amconsistentordering
8 Mar 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 98% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Tom Lane supplied the inline condition change and requested the accompanying comment adjustment in #9; both appear in src/backend/utils/cache/lsyscache.c. This follows up af4002b381 by making consistent ordering independent of ordered retrieval.

  • Peter Eisentrautsaw the final versioncommittercommitted the patch
Fix typo
8 Mar 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Tom Lane reported the duplicate amconsistentequality assignment introduced by af4002b381 in #9. The commit changes the second assignment to amconsistentordering in src/backend/access/hash/hash.c.

  • Tom Lanesaw the final versionLLM analysis, 100% sureIn #9, he identified the duplicate field assignment and specified the correct field before the fix was committed.
Rename amcancrosscompare
7 Mar 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 2 reviewers saw the final version

Following ce62f2f2a0, Tom Lane proposed separate amconsistentequality and amconsistentordering properties and clearer comments in #7. The commit adopts those properties across AM handlers, src/include/access/amapi.h, documentation, and compatibility checks, with comment revisions superseding Mark Dilger's inline wording in #6.

  • Tom Lanesaw the final versionLLM analysis, 99% sureIn #7, he specified the two semantic guarantees, proposed the adopted field names and comments, and identified the stale query_is_distinct_for documentation.
  • Mark Dilgersaw an earlier versionLLM analysis, 90% sureHe clarified the existing equality guarantee in #3 and supplied revised compatibility-function comments in #6, before the design split into separate equality and ordering properties.
Improve possible performance regression
7 Mar 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

In #7, Tom Lane identified expensive AM lookups introduced by ce62f2f2a0 and proposed checking op_in_opfamily first. The commit implements that nesting in both compatibility functions in src/backend/utils/cache/lsyscache.c.

  • Tom Lanesaw the final versionLLM analysis, 100% sureIn #7, he identified the performance concern and proposed the cheaper-check-first approach implemented by the commit.
Set amcancrosscompare to true for hash
1 Mar 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Tom Lane reported in #2 that ce62f2f2a0 incorrectly left hash without amcancrosscompare, and Mark Dilger confirmed the required setting in #3. The commit changes that flag from false to true in src/backend/access/hash/hash.c, as acknowledged in #4.

  • Mark Dilgersaw the final versiontrailerIn #3, he confirmed that hashhandler must set amcancrosscompare to true, exactly the correction committed.

Credits across 5 commits

Author
Tom LaneLLM1
Reviewer
Mark Dilger1
Peter Eisentrautcommitter1
Reported by
Tom Lane5
Committer
Peter Eisentraut5

N LLM means N of the credits come from LLM analysis, not from commit trailers.