Oddly indented raw_expression_tree_walker
Started by Takahiro Itagakialmost 16 years ago2 messages
I found raw_expression_tree_walker() is oddly indented in 8.4 and HEAD.
I expected pgindent would fix those clutter, but it could not.
Should we cleanup it manually, or leave it as-is?
Also, should we backport such kind of cleanups to previous releases?
Index: src/backend/nodes/nodeFuncs.c
===================================================================
@@ -2198,7 +2198,7 @@
* that could appear under it, but not other statement types.
*/
bool
- raw_expression_tree_walker(Node *node, bool (*walker) (), void *context)
+raw_expression_tree_walker(Node *node, bool (*walker) (), void *context)
{
ListCell *temp;
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
Re: Oddly indented raw_expression_tree_walker
Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp> writes:
I found raw_expression_tree_walker() is oddly indented in 8.4 and HEAD.
I expected pgindent would fix those clutter, but it could not.
Should we cleanup it manually, or leave it as-is?
There is exactly zero point in a manual cleanup, because pgindent will
just do it again next time. If you want to try to fix pgindent,
though, have at it.
regards, tom lane