pgsql: Add PGFILEDESC description to Makefiles for all /contrib
Log Message:
-----------
Add PGFILEDESC description to Makefiles for all /contrib executables.
Add PGAPPICON to all executable makefiles.
Modified Files:
--------------
pgsql/contrib/oid2name:
Makefile (r1.10 -> r1.11)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/contrib/oid2name/Makefile?r1=1.10&r2=1.11)
pgsql/contrib/pg_standby:
Makefile (r1.5 -> r1.6)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/contrib/pg_standby/Makefile?r1=1.5&r2=1.6)
pgsql/contrib/pg_upgrade:
Makefile (r1.1 -> r1.2)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/contrib/pg_upgrade/Makefile?r1=1.1&r2=1.2)
pgsql/contrib/pgbench:
Makefile (r1.17 -> r1.18)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/contrib/pgbench/Makefile?r1=1.17&r2=1.18)
pgsql/contrib/vacuumlo:
Makefile (r1.17 -> r1.18)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/contrib/vacuumlo/Makefile?r1=1.17&r2=1.18)
pgsql/src/backend:
Makefile (r1.141 -> r1.142)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/Makefile?r1=1.141&r2=1.142)
pgsql/src/bin/initdb:
Makefile (r1.59 -> r1.60)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/initdb/Makefile?r1=1.59&r2=1.60)
pgsql/src/bin/pg_config:
Makefile (r1.23 -> r1.24)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_config/Makefile?r1=1.23&r2=1.24)
pgsql/src/bin/pg_controldata:
Makefile (r1.20 -> r1.21)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_controldata/Makefile?r1=1.20&r2=1.21)
pgsql/src/bin/pg_ctl:
Makefile (r1.28 -> r1.29)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_ctl/Makefile?r1=1.28&r2=1.29)
pgsql/src/bin/pg_dump:
Makefile (r1.69 -> r1.70)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/Makefile?r1=1.69&r2=1.70)
pgsql/src/bin/pg_resetxlog:
Makefile (r1.22 -> r1.23)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_resetxlog/Makefile?r1=1.22&r2=1.23)
pgsql/src/bin/pgevent:
Makefile (r1.14 -> r1.15)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/pgevent/Makefile?r1=1.14&r2=1.15)
pgsql/src/bin/psql:
Makefile (r1.68 -> r1.69)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/psql/Makefile?r1=1.68&r2=1.69)
pgsql/src/bin/scripts:
Makefile (r1.44 -> r1.45)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/scripts/Makefile?r1=1.44&r2=1.45)
pgsql/src/interfaces/ecpg/preproc:
Makefile (r1.148 -> r1.149)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/ecpg/preproc/Makefile?r1=1.148&r2=1.149)
momjian@postgresql.org (Bruce Momjian) writes:
Add PGAPPICON to all executable makefiles.
Is it really a good idea to have done that to the server, in particular?
I can't imagine it being a good idea to launch the postmaster from a
GUI, which is what I suppose this is good for.
regards, tom lane
Tom Lane wrote:
momjian@postgresql.org (Bruce Momjian) writes:
Add PGAPPICON to all executable makefiles.
Is it really a good idea to have done that to the server, in particular?
I can't imagine it being a good idea to launch the postmaster from a
GUI, which is what I suppose this is good for.
Well, I assume this was the "icon", which I assumed should match for all
the binaries, as compared to config files, for example.
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
Bruce Momjian <bruce@momjian.us> writes:
Tom Lane wrote:
momjian@postgresql.org (Bruce Momjian) writes:
Add PGAPPICON to all executable makefiles.
Is it really a good idea to have done that to the server, in particular?
I can't imagine it being a good idea to launch the postmaster from a
GUI, which is what I suppose this is good for.
Well, I assume this was the "icon", which I assumed should match for all
the binaries, as compared to config files, for example.
Er... why are you committing undiscussed patches if you just "assume"
they will work, or indeed do anything useful at all? You should not
have touched this if you don't know exactly what it will do and why
changing it is a good thing.
regards, tom lane
Tom Lane wrote:
Bruce Momjian <bruce@momjian.us> writes:
Tom Lane wrote:
momjian@postgresql.org (Bruce Momjian) writes:
Add PGAPPICON to all executable makefiles.
Is it really a good idea to have done that to the server, in particular?
I can't imagine it being a good idea to launch the postmaster from a
GUI, which is what I suppose this is good for.Well, I assume this was the "icon", which I assumed should match for all
the binaries, as compared to config files, for example.Er... why are you committing undiscussed patches if you just "assume"
they will work, or indeed do anything useful at all? You should not
have touched this if you don't know exactly what it will do and why
changing it is a good thing.
All other binaries had such a designation, and all /contrib binaries
were missing them. I assume I was doing cleanup. You want the icon
removed from the backend makefile? I can easily do it.
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
Bruce Momjian <bruce@momjian.us> writes:
All other binaries had such a designation, and all /contrib binaries
were missing them. I assume I was doing cleanup. You want the icon
removed from the backend makefile?
Yes. I'm prepared to believe that not having the icons set on the
contrib executables was an oversight. I'm much less prepared to assume
that not marking the postgres executable was an oversight. Again,
unless you *know* that this change is needed and appropriate, now is
not the time to be making it, and especially not without discussion.
regards, tom lane
Tom Lane wrote:
Bruce Momjian <bruce@momjian.us> writes:
All other binaries had such a designation, and all /contrib binaries
were missing them. I assume I was doing cleanup. You want the icon
removed from the backend makefile?Yes. I'm prepared to believe that not having the icons set on the
contrib executables was an oversight. I'm much less prepared to assume
that not marking the postgres executable was an oversight. Again,
unless you *know* that this change is needed and appropriate, now is
not the time to be making it, and especially not without discussion.
OK, done with attached patch, and I added a comment about why it is not
labeled.
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
Attachments:
/rtmp/difftext/x-diffDownload
Index: src/backend/Makefile
===================================================================
RCS file: /cvsroot/pgsql/src/backend/Makefile,v
retrieving revision 1.142
diff -c -c -r1.142 Makefile
*** src/backend/Makefile 12 May 2010 11:33:09 -0000 1.142
--- src/backend/Makefile 12 May 2010 21:41:14 -0000
***************
*** 10,16 ****
#-------------------------------------------------------------------------
PGFILEDESC = "PostgreSQL Server"
! PGAPPICON=win32
subdir = src/backend
top_builddir = ../..
--- 10,17 ----
#-------------------------------------------------------------------------
PGFILEDESC = "PostgreSQL Server"
! # it is unclear that this should be labeled as an executable
! #PGAPPICON=win32
subdir = src/backend
top_builddir = ../..
bruce wrote:
Tom Lane wrote:
Bruce Momjian <bruce@momjian.us> writes:
All other binaries had such a designation, and all /contrib binaries
were missing them. I assume I was doing cleanup. You want the icon
removed from the backend makefile?Yes. I'm prepared to believe that not having the icons set on the
contrib executables was an oversight. I'm much less prepared to assume
that not marking the postgres executable was an oversight. Again,
unless you *know* that this change is needed and appropriate, now is
not the time to be making it, and especially not without discussion.OK, done with attached patch, and I added a comment about why it is not
labeled.
I did some research on PGFILEDESC and it does what I thought it does ---
in embeds the 'ico' file into the executable in
/pg/tools/msvc/Project.pm, and the image looks like the attached JPEG.
The image is of a blue elephant head.
So, currently, every binary uses that icon, except for the postmaster.
Is that what we want? You could make the argument that a daemon, like
the postmaster, shouldn't have one, which I think is Tom's point.
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
Attachments:
Import Notes
Reply to msg id not found: | Resolved by subject fallback
On Thu, May 13, 2010 at 1:47 AM, Bruce Momjian <bruce@momjian.us> wrote:
bruce wrote:
Tom Lane wrote:
Bruce Momjian <bruce@momjian.us> writes:
All other binaries had such a designation, and all /contrib binaries
were missing them. I assume I was doing cleanup. You want the icon
removed from the backend makefile?Yes. I'm prepared to believe that not having the icons set on the
contrib executables was an oversight. I'm much less prepared to assume
that not marking the postgres executable was an oversight. Again,
unless you *know* that this change is needed and appropriate, now is
not the time to be making it, and especially not without discussion.OK, done with attached patch, and I added a comment about why it is not
labeled.I did some research on PGFILEDESC and it does what I thought it does ---
in embeds the 'ico' file into the executable in
/pg/tools/msvc/Project.pm, and the image looks like the attached JPEG.
The image is of a blue elephant head.So, currently, every binary uses that icon, except for the postmaster.
Is that what we want? You could make the argument that a daemon, like
the postmaster, shouldn't have one, which I think is Tom's point.
It's pretty normal that daemons don't have icons.
One could argue the same for binaries that are normally never executed
by the user, just internally - but I don't think we have any of those
(we're talking EXE not DLL).
There is, AFAIK, no rule (hard or of-thumb) for "icons for GUI
programs only not commandline ones". Commandline tools usually have
it.
The argument to be made there is that when you go into the bin
directory you'll get greeted with a long list of identical elephants.
It would probably be better if we could have a *different* icon for
tools that the user is likely to execute himself - which is pretty
much just psql I think.
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
Magnus Hagander wrote:
On Thu, May 13, 2010 at 1:47 AM, Bruce Momjian <bruce@momjian.us> wrote:
bruce wrote:
Tom Lane wrote:
Bruce Momjian <bruce@momjian.us> writes:
All other binaries had such a designation, and all /contrib binaries
were missing them. ?I assume I was doing cleanup. ?You want the icon
removed from the backend makefile?Yes. ?I'm prepared to believe that not having the icons set on the
contrib executables was an oversight. ?I'm much less prepared to assume
that not marking the postgres executable was an oversight. ?Again,
unless you *know* that this change is needed and appropriate, now is
not the time to be making it, and especially not without discussion.OK, done with attached patch, and I added a comment about why it is not
labeled.I did some research on PGFILEDESC and it does what I thought it does ---
in embeds the 'ico' file into the executable in
/pg/tools/msvc/Project.pm, and the image looks like the attached JPEG.
The image is of a blue elephant head.So, currently, every binary uses that icon, except for the postmaster.
Is that what we want? ?You could make the argument that a daemon, like
the postmaster, shouldn't have one, which I think is Tom's point.It's pretty normal that daemons don't have icons.
Yes, that is the logic I was looking for and documented that in the
postmaster Makefile.
One could argue the same for binaries that are normally never executed
by the user, just internally - but I don't think we have any of those
(we're talking EXE not DLL).There is, AFAIK, no rule (hard or of-thumb) for "icons for GUI
programs only not commandline ones". Commandline tools usually have
it.The argument to be made there is that when you go into the bin
directory you'll get greeted with a long list of identical elephants.
It would probably be better if we could have a *different* icon for
tools that the user is likely to execute himself - which is pretty
much just psql I think.
All /bin stuff already had icons --- I just added icons to /contrib
binaries.
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com