The smallest patch (vacuumdb.c)

Started by Josh Berkusover 15 years ago3 messages
#1Josh Berkus
josh@agliodbs.com
1 attachment(s)

Folks,

Looks like someone accidentally deleted the -Z option from vacuumdb.
Patch attached, one character. ;-)

(thanks Gabrielle, and Jan Urbanski)

--
-- Josh Berkus
PostgreSQL Experts Inc.
http://www.pgexperts.com

Attachments:

vacuumdb_Z_patchtext/plain; name=vacuumdb_Z_patch; x-mac-creator=0; x-mac-type=0Download
? GNUmakefile
? config.log
? config.status
? force_quote_all-20090714.patch
? vacuumdb_Z_patch
? doc/src/sgml/features-supported.sgml
? doc/src/sgml/features-unsupported.sgml
? doc/src/sgml/release-8.4.2.sgml
? doc/src/sgml/release-8.5.jmb.sgml
? doc/src/sgml/version.sgml
? src/Makefile.global
? src/include/pg_config.h
? src/include/stamp-h
? src/interfaces/ecpg/include/ecpg_config.h
? src/interfaces/ecpg/include/stamp-h
Index: src/bin/scripts/vacuumdb.c
===================================================================
RCS file: /projects/cvsroot/pgsql/src/bin/scripts/vacuumdb.c,v
retrieving revision 1.37
diff -c -r1.37 vacuumdb.c
*** src/bin/scripts/vacuumdb.c	26 Feb 2010 04:14:36 -0000	1.37
--- src/bin/scripts/vacuumdb.c	11 Jun 2010 22:41:58 -0000
***************
*** 74,80 ****
  
  	handle_help_version_opts(argc, argv, "vacuumdb", help);
  
! 	while ((c = getopt_long(argc, argv, "h:p:U:wWeqd:zaFt:fv", long_options, &optindex)) != -1)
  	{
  		switch (c)
  		{
--- 74,80 ----
  
  	handle_help_version_opts(argc, argv, "vacuumdb", help);
  
! 	while ((c = getopt_long(argc, argv, "h:p:U:wWeqd:zZaFt:fv", long_options, &optindex)) != -1)
  	{
  		switch (c)
  		{
#2Josh Berkus
josh@agliodbs.com
In reply to: Josh Berkus (#1)
1 attachment(s)
Re: The smallest patch (vacuumdb.c)

On 6/11/10 3:44 PM, Josh Berkus wrote:

Folks,

Looks like someone accidentally deleted the -Z option from vacuumdb.
Patch attached, one character. ;-)

Make that 3 characters; Jan pointed out that we ought to have the
command-string in the same order as the switch options.

--
-- Josh Berkus
PostgreSQL Experts Inc.
http://www.pgexperts.com

Attachments:

vacuumdb_Z_patchtext/plain; name=vacuumdb_Z_patch; x-mac-creator=0; x-mac-type=0Download
diff -c -r1.37 vacuumdb.c
*** src/bin/scripts/vacuumdb.c	26 Feb 2010 04:14:36 -0000	1.37
--- src/bin/scripts/vacuumdb.c	11 Jun 2010 22:41:58 -0000
***************
*** 74,80 ****
  
  	handle_help_version_opts(argc, argv, "vacuumdb", help);
  
! 	while ((c = getopt_long(argc, argv, "h:p:U:wWeqd:zaFt:fv", long_options, &optindex)) != -1)
  	{
  		switch (c)
  		{
--- 74,80 ----
  
  	handle_help_version_opts(argc, argv, "vacuumdb", help);
  
! 	while ((c = getopt_long(argc, argv, "h:p:U:wWeqd:zZFat:fv", long_options, &optindex)) != -1)
  	{
  		switch (c)
  		{
#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Josh Berkus (#2)
Re: The smallest patch (vacuumdb.c)

Josh Berkus <josh@agliodbs.com> writes:

Looks like someone accidentally deleted the -Z option from vacuumdb.

Forgot to add it in the first place, looks like.

Patch attached, one character. ;-)

Make that 3 characters; Jan pointed out that we ought to have the
command-string in the same order as the switch options.

Applied.

regards, tom lane