GetOldestWALSendPointer() in header

Started by Takahiro Itagakiover 15 years ago2 messages

itagaki.takahiro@oss.ntt.co.jp

over 15 years ago

Hi,

GetOldestWALSendPointer() is commented out in the source code
with NOT_USED block, but is still declared in the header file.
Should we remove the function prototype from walsender.h ?

[walsender.h]
extern XLogRecPtr GetOldestWALSendPointer(void);

Regards,
---
Takahiro Itagaki
NTT Open Source Software Center

Tom Lane

tgl@sss.pgh.pa.us

over 15 years ago

In reply to: Takahiro Itagaki (#1)

Re: GetOldestWALSendPointer() in header

Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp> writes:

GetOldestWALSendPointer() is commented out in the source code
with NOT_USED block, but is still declared in the header file.
Should we remove the function prototype from walsender.h ?

Yes, that's our usual convention.

regards, tom lane