model-writtenrun 1552 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- The thread began with Michael Paquier's announcement that custom pgstats coverage was being removed from injection_points for relocation into a separate test module; Tom Lane then reported broken cross-version upgrade tests and questioned requiring upgrade compatibility from test libraries #1 #2.
- Michael identified gin, typcache and nbtree as leaving injection_points installed and proposed version-gated database removal in AdjustUpgrade.pm, while Tom requested discussion before applying the workaround #3 #4.
- Michael discovered that the proposed database names only matched Meson: configure derived different names from REGRESS, making the attachment ineffective for some buildfarm members #5.
- Heikki Linnakangas proposed deriving configure's regression database names from module directories, but Tom warned that changing names would complicate historical upgrade testing unless extensively backpatched; this independent naming patch did not land in either candidate commit #6 #7.
- Tom suggested dropping injection_points at the end of affected tests; Heikki raised a possible race between the nbtree scripts and proposed scheduled setup and cleanup phases #7 #8.
- Michael preferred extension cleanup if buildfarm dumps would be regenerated, and Tom confirmed that new runs on the old branches refresh those dumps, leading Michael to choose backpatched cleanup #9 #10 #11.
- Heikki endorsed proceeding, and Michael established that the nbtree scripts already run serially, allowing cleanup in each script without a schedule; Michael also noted that shared setup names would collide under the existing database-naming rules #12 #13.
- Michael separately fixed the missing nbtree_half_dead_pages entry in REGRESS and the missing module .gitignore in 06817fc8a4, implementing omissions he had reported during the investigation #11 #13 #14.
- Michael committed per-script extension cleanup and corresponding expected output as 1d7b00dc14, with applicable fixes backpatched through version 17, replacing the attached AdjustUpgrade.pm workaround with the solution developed in discussion #14.
- Michael reported that crake was green, and Heikki closed with thanks; the upgrade failure and incidental nbtree omissions were resolved, with no further disposition recorded for the database-naming proposal #15 #16.